Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pcntl tests stability #2841

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Sep 6, 2024

Description

It look more stable :finger_crossed:; it passed three times in a row.

There were several kinds of errors that could have occurred:

  • The order of requests is not guaranteed.
  • The number of requests (traces may have been grouped into a single request).
  • A timeout could have occurred before the background sender finished sending traces.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (98839cf) to head (dc22678).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2841   +/-   ##
=========================================
  Coverage     81.06%   81.06%           
  Complexity     2516     2516           
=========================================
  Files           146      146           
  Lines         14653    14653           
=========================================
  Hits          11879    11879           
  Misses         2774     2774           
Flag Coverage Δ
tracer-extension 78.18% <ø> (ø)
tracer-php 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98839cf...dc22678. Read the comment docs.

@iamluc iamluc force-pushed the luc/improve-pcntl-tests-stability branch 6 times, most recently from 0234892 to 268937f Compare September 9, 2024 12:04
@iamluc iamluc force-pushed the luc/improve-pcntl-tests-stability branch 4 times, most recently from a69518d to 791d982 Compare September 9, 2024 14:43
@iamluc iamluc force-pushed the luc/improve-pcntl-tests-stability branch 2 times, most recently from dcb0947 to acc2d74 Compare September 10, 2024 07:39
@iamluc iamluc force-pushed the luc/improve-pcntl-tests-stability branch 3 times, most recently from f1537af to 54ae5b9 Compare September 11, 2024 09:21
@iamluc iamluc force-pushed the luc/improve-pcntl-tests-stability branch from 54ae5b9 to 8f6c25d Compare September 11, 2024 09:41
@iamluc iamluc force-pushed the luc/improve-pcntl-tests-stability branch 3 times, most recently from 9d4b6f1 to 79cfe2f Compare September 11, 2024 12:56
@iamluc iamluc force-pushed the luc/improve-pcntl-tests-stability branch from 79cfe2f to dc22678 Compare September 11, 2024 13:09
@iamluc iamluc marked this pull request as ready for review September 11, 2024 13:37
@iamluc iamluc requested a review from a team as a code owner September 11, 2024 13:37
@iamluc iamluc merged commit ebaa1ca into master Sep 12, 2024
644 of 645 checks passed
@iamluc iamluc deleted the luc/improve-pcntl-tests-stability branch September 12, 2024 08:04
@github-actions github-actions bot added this to the 1.4.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants