-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling) add thread names #2934
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2934 +/- ##
============================================
- Coverage 82.10% 73.97% -8.13%
Complexity 2527 2527
============================================
Files 108 108
Lines 10360 10360
============================================
- Hits 8506 7664 -842
- Misses 1854 2696 +842
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ profiler ]Benchmark execution time: 2024-11-12 08:02:08 Comparing candidate commit 1b4be1c in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 26 metrics, 9 unstable metrics. scenario:php-profiler-timeline-memory-with-profiler
|
856fa9f
to
456263a
Compare
d5f66f6
to
2b2115b
Compare
2b2115b
to
0f4bcd2
Compare
Description
This PR will add a
thread name
label to collected samples. In most cases a dedicated thread name is either not set or even if it is not helpful. For NTS PHP we do just use the SAPI name as the thread name, this seems helpful. For ZTS we currently only collect a thread name for FrankenPHP as it sets meaningful names.Additional notes:
In the future we should try and detect Apache and parallel threads and name them accordingly.
PROF-10863
Reviewer checklist