Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update PHP 8.4 to rc4 #2938

Merged
merged 2 commits into from
Nov 8, 2024
Merged

ci: update PHP 8.4 to rc4 #2938

merged 2 commits into from
Nov 8, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Nov 8, 2024

Description

PHP 8.4 RC4 got released, this updates docker images to the latest rc

PROF-10137

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing area:asm labels Nov 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (68f8558) to head (b3b784f).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2938   +/-   ##
=========================================
  Coverage     82.10%   82.10%           
  Complexity     2527     2527           
=========================================
  Files           108      108           
  Lines         10360    10360           
=========================================
  Hits           8506     8506           
  Misses         1854     1854           
Flag Coverage Δ
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f8558...b3b784f. Read the comment docs.

@realFlowControl realFlowControl marked this pull request as ready for review November 8, 2024 12:53
@realFlowControl realFlowControl requested a review from a team as a code owner November 8, 2024 12:53
@realFlowControl
Copy link
Member Author

All PHP 8.4 images have already been rebuild on PHP 8.4 RC4

@realFlowControl realFlowControl merged commit 84f7fa8 into master Nov 8, 2024
425 of 475 checks passed
@realFlowControl realFlowControl deleted the florian/update-php branch November 8, 2024 13:00
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:asm profiling Relates to the Continuous Profiler tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants