Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libddwaf to v1.22.0 #3007

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Upgrade libddwaf to v1.22.0 #3007

merged 2 commits into from
Dec 19, 2024

Conversation

Anilm3
Copy link
Contributor

@Anilm3 Anilm3 commented Dec 19, 2024

Description

This PR upgrades libddwaf to v1.22.0 and fixes a few tests:

  • Failures due to the fact that the WAF will evaluate some rules even with a timeout of 0 (denylists).
  • Failures due to rule order expectations in the integration tests.

Related Jiras: APPSEC-56195

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@Anilm3 Anilm3 requested a review from a team as a code owner December 19, 2024 14:59
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.74%. Comparing base (0d57b55) to head (7c4b3c2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3007      +/-   ##
============================================
+ Coverage     72.72%   72.74%   +0.01%     
  Complexity     2750     2750              
============================================
  Files           138      138              
  Lines         15060    15060              
  Branches       1026     1026              
============================================
+ Hits          10953    10955       +2     
+ Misses         3548     3546       -2     
  Partials        559      559              
Flag Coverage Δ
appsec-extension 67.95% <ø> (ø)
tracer-php 74.56% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d57b55...7c4b3c2. Read the comment docs.

@Anilm3 Anilm3 merged commit dc9911b into master Dec 19, 2024
713 of 751 checks passed
@Anilm3 Anilm3 deleted the anilm3/upgrade-libddwaf-1.22.0 branch December 19, 2024 16:03
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants