fix(prof): PHP 8.4 crash with opcache optimizer #3038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The profiler may crash when:
If allocation profiling triggers at a precise spot in the optimizer, then it will dereference a null pointer. The reason is that the optimizer puts a fake frame with a zeroed opline in
accel_preload
, and the profiler does not check for null at this location.There are other access in the profiler to the opline such as
extract_file_and_line
, but they already guard against a null pointer. This specific bit of code that did not guard was added for PHP 8.4 to handle frameless functions, a new optimization in PHP 8.4.Reviewer checklist