Skip to content

Commit

Permalink
chore(profiling): native extensions are no longer optional on support…
Browse files Browse the repository at this point in the history
…ed platforms (#9169)

This patch changes the affinity for certain profiling-related
extensions. They were marked as optional during our vetting process, but
now should be built everywhere. This isn't a problem for CI. Serverless
currently strips these components out post-build, and that's still OK.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: sanchda <sanchda@users.noreply.github.com>
  • Loading branch information
sanchda and sanchda authored Jun 20, 2024
1 parent f33856b commit 0b1e1ce
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@

DEBUG_COMPILE = "DD_COMPILE_DEBUG" in os.environ

# stack_v2 profiling extensions are optional, unless they are made explicitly required by this environment variable
STACK_V2_REQUIRED = "DD_STACK_V2_REQUIRED" in os.environ

IS_PYSTON = hasattr(sys, "pyston_version_info")

LIBDDWAF_DOWNLOAD_DIR = HERE / "ddtrace" / "appsec" / "_ddwaf" / "libddwaf"
Expand Down Expand Up @@ -462,7 +459,7 @@ def get_exts_for(name):
"-DPY_MINOR_VERSION={}".format(sys.version_info.minor),
"-DPY_MICRO_VERSION={}".format(sys.version_info.micro),
],
optional=not STACK_V2_REQUIRED,
optional=False,
)
)

Expand All @@ -472,7 +469,7 @@ def get_exts_for(name):
CMakeExtension(
"ddtrace.internal.datadog.profiling.stack_v2._stack_v2",
source_dir=STACK_V2_DIR,
optional=not STACK_V2_REQUIRED,
optional=False,
),
)

Expand Down

0 comments on commit 0b1e1ce

Please sign in to comment.