Skip to content

Commit

Permalink
chore(ci): update to run gitlab test suites on any lockfile change [b…
Browse files Browse the repository at this point in the history
…ackport 2.17] (#11560)

Backport 5ac21cc from #11536 to 2.17.

When the requirement lockfiles are updated, the test suite corresponding
to the riot hash / venv is not always run. As a workaround, this
modifies the logic to trigger all test suites when a lockfile is
updated.

In the future, we can modify this logic to be more fine-grained and
capture only the relevant test suites for the modified lockfiles.

Example test PR that triggers all circleci and gitlab test suites to
run: #11541

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Quinna Halim <quinna.halim@datadoghq.com>
  • Loading branch information
github-actions[bot] and quinna-h authored Nov 27, 2024
1 parent 09d6215 commit 7b66061
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/.suitespec.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"docker/*",
"docker-compose.yml",
"riotfile.py",
".riot/requirements/*",
"scripts/ddtest",
"scripts/run-test-suite",
"hatch.toml",
Expand Down

0 comments on commit 7b66061

Please sign in to comment.