Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(celery): flatten context
delivery_info
tags (#4772)
## Description Tag data from celery is included as a raw string representation for `delivery_info`, which makes it impossible to use as a facet or measure in APM. The fix is necessary because routing info is valuable to have when understanding why delays happen between task creation and task execution. Issue #4771. This is only breaking for the tag output format from celery spans, and should only break any cases currently modifying or depending on dicts to be represented as raw strings. ## Checklist - [x] Followed the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) when writing a release note. - [x] Add additional sections for `feat` and `fix` pull requests. - [x] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. <!-- Copy and paste the relevant snippet based on the type of pull request --> <!-- START fix --> ## Relevant issue(s) Fixes #4771 ## Testing strategy Modified existing unit tests to expect the new tag structure. Manually tested on project that included celery to ensure expected dictionary (`delivery_info`) would be flattened as expected. <!-- END fix --> ## Reviewer Checklist - [x] Title is accurate. - [x] Description motivates each change. - [x] No unnecessary changes were introduced in this PR. - [x] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Tests provided or description of manual testing performed is included in the code or PR. - [x] Release note has been added and follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines), or else `changelog/no-changelog` label added. - [x] All relevant GitHub issues are correctly linked. - [x] Backports are identified and tagged with Mergifyio. Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
- Loading branch information