Skip to content

Commit

Permalink
ci(asm): fix fastapi tests (#11580)
Browse files Browse the repository at this point in the history
httpx 0.28.0 is breaking our tests. This PR pins httpx version for
fastapi threat tests.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 17631cf)
  • Loading branch information
christophe-papazian authored and github-actions[bot] committed Nov 28, 2024
1 parent dc0d0ed commit ba5e520
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hatch.toml
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ dependencies = [
"pytest-cov",
"requests",
"hypothesis",
"httpx",
"httpx<0.28.0",
"anyio{matrix:anyio:}",
"fastapi{matrix:fastapi}"
]
Expand Down

0 comments on commit ba5e520

Please sign in to comment.