Commit bdad60b
fix(tracing): span pointer __repr__ [backport 3.12] (#14547)
Backport 2b8bd63 from #14539 to 3.12.
## What's the issue
In the _SpanPointer.__repr__ method, it's trying to access
self.direction and self.hash, but these attributes don't exist on the
object. The _SpanPointer class:
1. It inherits from SpanLink
2. The direction and hash information are stored in the attributes
dictionary as "ptr.dir" and "ptr.hash"
Therefore the fix.
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Co-authored-by: Joey Zhao <5253430+joeyzhao2018@users.noreply.github.com>1 parent bddcb7d commit bdad60b
File tree
3 files changed
+10
-3
lines changed- ddtrace/_trace
- releasenotes/notes
- tests/tracer
3 files changed
+10
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
| 68 | + | |
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
855 | 855 | | |
856 | 856 | | |
857 | 857 | | |
| 858 | + | |
858 | 859 | | |
859 | 860 | | |
860 | 861 | | |
| |||
867 | 868 | | |
868 | 869 | | |
869 | 870 | | |
870 | | - | |
871 | | - | |
| 871 | + | |
| 872 | + | |
872 | 873 | | |
| 874 | + | |
| 875 | + | |
873 | 876 | | |
874 | 877 | | |
875 | 878 | | |
| |||
0 commit comments