-
Notifications
You must be signed in to change notification settings - Fork 470
fix(tracing): span pointer __repr__ [backport 3.12] #14547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
In the _SpanPointer.__repr__ method, it's trying to access self.direction and self.hash, but these attributes don't exist on the object. The _SpanPointer class: 1. It inherits from SpanLink 2. The direction and hash information are stored in the attributes dictionary as "ptr.dir" and "ptr.hash" Therefore the fix. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 2b8bd63)
2cd4bec to
9db21bc
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 268 ± 4 ms. The average import time from base is: 269 ± 2 ms. The import time difference between this PR and base is: -1.4 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: backport-14539-to-3.12 (9db21bc) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
Backport 2b8bd63 from #14539 to 3.12.
What's the issue
In the _SpanPointer.repr method, it's trying to access self.direction and self.hash, but these attributes don't exist on the object. The _SpanPointer class:
Therefore the fix.
Checklist
Reviewer Checklist