Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear docs around dd-trace-py and gunicorn #5248

Closed
lattwood opened this issue Mar 2, 2023 · 2 comments
Closed

Unclear docs around dd-trace-py and gunicorn #5248

lattwood opened this issue Mar 2, 2023 · 2 comments

Comments

@lattwood
Copy link

lattwood commented Mar 2, 2023

On the "Advanced Usage" page, this example is given for Gunicorn.
image

But on the gunicorn integrations page, it says ddtrace-run doesn't work?

image

Does this mean the only supported worker type is gevent under Gunicorn, or that if you want to use the gevent worker type you have to jump through hoops, and the other worker types are supported?

Docs are unclear, hence asking :\
@Yun-Kim
Copy link
Contributor

Yun-Kim commented Mar 2, 2023

Hi @lattwood, sorry about the confusion.
You are correct, ddtrace-run supports Gunicorn when not using Gunicorn's gevent type workers. If you want to use the gevent worker type you have to meet the specified conditions.
We'll change the docs to clarify this.

@Yun-Kim Yun-Kim mentioned this issue Mar 2, 2023
Closed
15 tasks
@mabdinur
Copy link
Contributor

mabdinur commented Mar 8, 2023 •
edited
Loading

Hi @lattwood,

Thanks for calling out this issue. We updated our gevent support and deprecated DD_GEVENT_PATCH_ALL configuration (PR). This should simplify tracing with gunicorn. These changes will be included in our next release.

ddtrace v1.10 will be released with the following changes to our docs:

Feel free to reopen this issue if you have additional concerns.

@mabdinur mabdinur closed this as completed Mar 8, 2023
lgarvey added a commit to uktrade/demodjango that referenced this issue Oct 28, 2024
@lgarvey
Add ddtrace-run to Procfile commands
79b6120 
As per
DataDog/dd-trace-py#5248

Note: it looks like ddtrace-run doesn't support gevent natively, but can be made to support it but only if the py version is <= py10

This isn't an issue with demodjango but may be with other applications.
@lgarvey lgarvey mentioned this issue Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(docs): clarify gunicorn/gevent documentation DataDog/dd-trace-py
3 participants
@lattwood @Yun-Kim @mabdinur