Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade testrunner image #10405

Merged
merged 11 commits into from
Aug 28, 2024
Merged

chore: upgrade testrunner image #10405

merged 11 commits into from
Aug 28, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Aug 27, 2024

  1. Upgrade testrunner image to the one generated by chore: update hatch version and remove hatch-containers #10373
  2. testrunner now runs python 3.11.9 (upgraded from 3.11.3) and gevent isn't compatible with python 3.11.9, GH-114781 potentially breaks gevent: threading becomes pre-imported at startup python/cpython#117983, so update the test to run when version < 3.11.9
  3. Regenerate riot file for appsec_integrations using python 3.12, as outdated pydantic doesn't work with 3.12.4, see TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard' pydantic/pydantic#9637. This also resulted in updating pytest version and setup_module is used instead of setup.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim marked this pull request as ready for review August 27, 2024 15:22
@taegyunkim taegyunkim requested review from a team as code owners August 27, 2024 15:22
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2024
Copy link
Contributor

github-actions bot commented Aug 27, 2024

CODEOWNERS have been resolved as:

.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/requirements-locks.yml                                @DataDog/python-guild @DataDog/apm-core-python
.gitlab-ci.yml                                                          @DataDog/apm-core-python
.riot/requirements/1e2d655.txt                                          @DataDog/apm-python
docker-compose.yml                                                      @DataDog/apm-core-python
hatch.toml                                                              @DataDog/python-guild
scripts/ddtest                                                          @DataDog/apm-core-python
tests/appsec/integrations/pygoat_tests/Dockerfile.pygoat.2.0.1          @DataDog/asm-python
tests/appsec/integrations/test_psycopg2.py                              @DataDog/asm-python
tests/profiling/collector/test_stack.py                                 @DataDog/profiling-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 27, 2024

Datadog Report

Branch report: taegyunkim/testrunner-update
Commit report: 6a0d95a
Test service: dd-trace-py

✅ 0 Failed, 141229 Passed, 1659 Skipped, 5h 32m 20.11s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Aug 27, 2024

Benchmarks

Benchmark execution time: 2024-08-28 15:41:51

Comparing candidate commit 6a0d95a in PR branch taegyunkim/testrunner-update with baseline commit 3569551 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@taegyunkim taegyunkim force-pushed the taegyunkim/testrunner-update branch from ccf99db to 40a96ad Compare August 27, 2024 16:08
@brettlangdon brettlangdon enabled auto-merge (squash) August 27, 2024 16:11
@taegyunkim taegyunkim disabled auto-merge August 27, 2024 16:18
@taegyunkim
Copy link
Contributor Author

Turned off auto-merge as it didn't trigger gitlab pipelines for some reason, and want to see gitlab pipelines running successfully.

@taegyunkim taegyunkim requested a review from a team as a code owner August 27, 2024 20:12
@taegyunkim taegyunkim force-pushed the taegyunkim/testrunner-update branch from dda2684 to 4795bda Compare August 27, 2024 20:12
@taegyunkim taegyunkim requested a review from a team as a code owner August 27, 2024 20:38
@taegyunkim taegyunkim requested a review from a team as a code owner August 28, 2024 00:41
@taegyunkim taegyunkim force-pushed the taegyunkim/testrunner-update branch from 82428da to 46b7751 Compare August 28, 2024 00:41
@taegyunkim taegyunkim enabled auto-merge (squash) August 28, 2024 00:54
hatch.toml Outdated Show resolved Hide resolved
@taegyunkim taegyunkim force-pushed the taegyunkim/testrunner-update branch 2 times, most recently from f16046e to 8c032e3 Compare August 28, 2024 14:08
Copy link
Contributor

@P403n1x87 P403n1x87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thanks!

@taegyunkim taegyunkim force-pushed the taegyunkim/testrunner-update branch from 8c032e3 to 6a0d95a Compare August 28, 2024 15:06
@taegyunkim taegyunkim merged commit 3eed1c2 into main Aug 28, 2024
206 of 207 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/testrunner-update branch August 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants