-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(celery): change out.host tags to point to celery broker #10750
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 1097 Passed, 281 Skipped, 8m 50.59s Total duration (17m 43.95s time saved) |
BenchmarksBenchmark execution time: 2024-11-25 20:34:07 Comparing candidate commit 96695f1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics. |
Co-authored-by: Zachary Groves <32471391+ZStriker19@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with a suggestion
…d-trace-py into zachg/fix_celery_outgoing_tags
/merge |
Devflow running:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also approving, but left a note about a possible edge case.
Co-authored-by: wconti27 <william.conti@datadoghq.com> (cherry picked from commit b9573be)
… 2.17] (#11540) Backport b9573be from #10750 to 2.17. ## Motivation Change `out.host` tags to point towards the celery broker, instead of the local celery hostname. Fixes service-representation issues. Fixes [11491](#11491) ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Zachary Groves <32471391+ZStriker19@users.noreply.github.com> Co-authored-by: William Conti <58711692+wconti27@users.noreply.github.com> Co-authored-by: William Conti <william.conti@datadoghq.com>
Motivation
Change
out.host
tags to point towards the celery broker, instead of the local celery hostname. Fixes service-representation issues.Fixes 11491
Checklist
Reviewer Checklist