Skip to content

chore: ignore crashtracker binary in git #10896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Oct 1, 2024

With fix(profiling): platform-specific files should have platform-specific filenames, crashtracker binaries have trailing platform specific strings in their names, e.g. crashtracker_exe-glibc-aarch64

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner October 1, 2024 21:56
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CODEOWNERS have been resolved as:

.gitignore                                                              @DataDog/apm-core-python

@taegyunkim taegyunkim enabled auto-merge (squash) October 1, 2024 22:14
@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024

Benchmarks

Benchmark execution time: 2024-10-01 22:37:04

Comparing candidate commit 3a8641c in PR branch taegyunkim/crashtracker-gitignore with baseline commit 0ce5741 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

@taegyunkim taegyunkim merged commit ade370a into main Oct 1, 2024
510 of 513 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/crashtracker-gitignore branch October 1, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants