Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci_visibility): avoid git tracebacks when .git dir is absent [backport 2.15] #11198

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix(ci_visibility): avoid git tracebacks when .git dir is absent [backport 2.15] #11198

merged 2 commits into from
Oct 29, 2024
+31 −1

Conversation

github-actions[bot]
Copy link
Contributor

Backport 5051de3 from #11175 to 2.15.

Fixes #10983 where the git metadata upload would log exceptions when trying to upload git metadata without a working git environment (eg: missing git executable or no .git directory).

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog @github-actions
fix(ci_visibility): avoid git tracebacks when .git dir is absent (#11175
b60ec65 
)

Fixes #10983 where the git metadata upload would log exceptions when
trying to upload git metadata without a working `git` environment (eg:
missing `git` executable or no `.git` directory).

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Brett Higgins <brett.higgins@gmail.com>
(cherry picked from commit 5051de3)
@github-actions github-actions bot requested review from a team as code owners October 28, 2024 10:23
@romainkomorndatadog romainkomorndatadog enabled auto-merge (squash) October 28, 2024 10:24
@pr-commenter
Copy link

pr-commenter bot commented Oct 28, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-10-28 17:02:08

Comparing candidate commit dcf9b27 in PR branch backport-11175-to-2.15 with baseline commit 242dd30 in branch 2.15.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

@github-actions GitHub Actions
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/ci_visibility-fix_logged_errors_when_gitless-66a6cb3245314f3e.yaml  @DataDog/apm-python
ddtrace/internal/ci_visibility/git_client.py                            @DataDog/ci-app-libraries
tests/ci_visibility/test_ci_visibility.py                               @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest.py                                     @DataDog/ci-app-libraries

@romainkomorndatadog romainkomorndatadog merged commit a5b6377 into 2.15 Oct 29, 2024
618 of 629 checks passed
@romainkomorndatadog romainkomorndatadog deleted the backport-11175-to-2.15 branch October 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainkomorndatadog romainkomorndatadog romainkomorndatadog approved these changes

@daniel-mohedano daniel-mohedano Awaiting requested review from daniel-mohedano daniel-mohedano is a code owner automatically assigned from DataDog/ci-app-libraries

@juanjux juanjux Awaiting requested review from juanjux juanjux is a code owner automatically assigned from DataDog/apm-python

@quinna-h quinna-h Awaiting requested review from quinna-h quinna-h is a code owner automatically assigned from DataDog/apm-python

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romainkomorndatadog