Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(symdb): upload compressed symbol payloads #11404

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Nov 14, 2024

We add support for compressed symbol database payloads.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 14, 2024
@P403n1x87 P403n1x87 self-assigned this Nov 14, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/symbol_db/symbols.py                                   @DataDog/debugger-python
ddtrace/internal/utils/http.py                                          @DataDog/apm-core-python

Copy link
Member

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 14, 2024

Datadog Report

Branch report: chore/symdb-compressed
Commit report: e556f43
Test service: dd-trace-py

✅ 0 Failed, 910 Passed, 376 Skipped, 21m 24.85s Total duration (12m 51.22s time saved)

@P403n1x87 P403n1x87 force-pushed the chore/symdb-compressed branch from 1fd0d33 to 1e05b69 Compare November 14, 2024 11:17
@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2024

Benchmarks

Benchmark execution time: 2024-12-11 15:12:25

Comparing candidate commit eb77fbc in PR branch chore/symdb-compressed with baseline commit 07db667 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@P403n1x87 P403n1x87 force-pushed the chore/symdb-compressed branch from 1e05b69 to 0a9a329 Compare November 28, 2024 12:56
We add support for compressed symbol database payloads.
@P403n1x87 P403n1x87 force-pushed the chore/symdb-compressed branch from 0a9a329 to e556f43 Compare November 28, 2024 16:02
@P403n1x87 P403n1x87 marked this pull request as ready for review November 28, 2024 16:04
@P403n1x87 P403n1x87 requested review from a team as code owners November 28, 2024 16:04
@P403n1x87 P403n1x87 added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Dec 2, 2024
@P403n1x87 P403n1x87 enabled auto-merge (squash) December 11, 2024 13:10
@P403n1x87 P403n1x87 merged commit aec08be into main Dec 11, 2024
588 of 589 checks passed
@P403n1x87 P403n1x87 deleted the chore/symdb-compressed branch December 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants