Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): fix telemetry for events and API requests #11545

Merged

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented Nov 26, 2024

This fixes some internal telemetry that was using enum names instead of their value, which was creating metrics or tags with the wrong names.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog romainkomorndatadog added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 26, 2024
@romainkomorndatadog romainkomorndatadog self-assigned this Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/ci_visibility/_api_client.py                           @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/recorder.py                              @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/telemetry/early_flake_detection.py       @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/telemetry/events.py                      @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/telemetry/git.py                         @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/utils.py                                 @DataDog/ci-app-libraries

@romainkomorndatadog romainkomorndatadog marked this pull request as ready for review November 26, 2024 14:15
@romainkomorndatadog romainkomorndatadog requested a review from a team as a code owner November 26, 2024 14:15
@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2024

Benchmarks

Benchmark execution time: 2024-11-26 15:19:39

Comparing candidate commit a73c385 in PR branch romain.komorn/chore/civisibility_telemetry_fixes with baseline commit 7dd3965 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 386 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathjoin_aspect

  • 🟩 execution_time [-500.339ns; -433.177ns] or [-9.045%; -7.831%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟩 execution_time [-369.219ns; -314.703ns] or [-9.424%; -8.032%]

@romainkomorndatadog romainkomorndatadog merged commit 5dfd7f0 into main Nov 26, 2024
216 checks passed
@romainkomorndatadog romainkomorndatadog deleted the romain.komorn/chore/civisibility_telemetry_fixes branch November 26, 2024 15:44
@romainkomorndatadog romainkomorndatadog restored the romain.komorn/chore/civisibility_telemetry_fixes branch November 26, 2024 16:08
romainkomorndatadog added a commit that referenced this pull request Nov 26, 2024
… better logging (#11549)

Follow-up to #11545 that was missed in the last PR.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants