-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci_visibility): fix telemetry for events and API requests #11545
Merged
romainkomorndatadog
merged 3 commits into
main
from
romain.komorn/chore/civisibility_telemetry_fixes
Nov 26, 2024
Merged
chore(ci_visibility): fix telemetry for events and API requests #11545
romainkomorndatadog
merged 3 commits into
main
from
romain.komorn/chore/civisibility_telemetry_fixes
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romainkomorndatadog
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
Nov 26, 2024
|
vitor-de-araujo
approved these changes
Nov 26, 2024
BenchmarksBenchmark execution time: 2024-11-26 15:19:39 Comparing candidate commit a73c385 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 386 metrics, 2 unstable metrics. scenario:iast_aspects-ospathjoin_aspect
scenario:iast_aspects-ospathsplitext_aspect
|
romainkomorndatadog
deleted the
romain.komorn/chore/civisibility_telemetry_fixes
branch
November 26, 2024 15:44
romainkomorndatadog
restored the
romain.komorn/chore/civisibility_telemetry_fixes
branch
November 26, 2024 16:08
2 tasks
romainkomorndatadog
added a commit
that referenced
this pull request
Nov 26, 2024
… better logging (#11549) Follow-up to #11545 that was missed in the last PR. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some internal telemetry that was using enum names instead of their value, which was creating metrics or tags with the wrong names.
Checklist
Reviewer Checklist