-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't skip heartbeats for forked processes #11575
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
|
Datadog ReportBranch report: ✅ 0 Failed, 1468 Passed, 0 Skipped, 23m 42.76s Total duration (12m 58s time saved) |
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
BenchmarksBenchmark execution time: 2024-11-29 10:14:56 Comparing candidate commit 3dd0da7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics. |
Description
We were skipping app-heartbeat messages for forked processes. The problem with this is that if a process doesn't sent a heartbeat in 60 minutes, the backend will forget its dependencies, which was causing the list to only be the updated ones for some clients, specifically with gunicorn.
This makes forked processes also sent heartbeats with solved the issue in our tests.
Will stay as draft PR until I can check with @brettlangdon the reason heartbeats were disabled for forks.
Checklist
Reviewer Checklist