Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(asm): fix fastapi tests [backport 2.11] #11581

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 28, 2024

Backport 17631cf from #11580 to 2.11.

httpx 0.28.0 is breaking our tests. This PR pins httpx version for fastapi threat tests.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

httpx 0.28.0 is breaking our tests. This PR pins httpx version for
fastapi threat tests.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 17631cf)
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring CI labels Nov 28, 2024
@github-actions github-actions bot requested a review from a team as a code owner November 28, 2024 18:00
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 28, 2024

Datadog Report

Branch report: backport-11580-to-2.11
Commit report: c78fba3
Test service: dd-trace-py

❌ 1 Failed (0 Known Flaky), 176866 Passed, 2451 Skipped, 10h 22m 46.02s Total duration (2h 17m 5.4s time saved)
❄️ 4 New Flaky

❌ Failed Tests (1)

  • test_appsec_enabled_attack - test_django_appsec_snapshots.py - Details

    Expand for error
     Unexpected test failure during snapshot test: HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f9c8c83cfd0>: Failed to establish a new connection: [Errno 111] Connection refused'))
    

New Flaky Tests (4)

  • test_appsec_enabled - test_django_appsec_snapshots.py - Last Failure

    Expand for error
     Unexpected test failure during snapshot test: HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f9c8439f8b0>: Failed to establish a new connection: [Errno 111] Connection refused'))
    
  • test_templates_enabled - test_django_snapshots.py - Last Failure

    Expand for error
     Unexpected test failure during snapshot test: HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fa54418f760>: Failed to establish a new connection: [Errno 111] Connection refused'))
    
  • test_service_name_config_override - test_elasticsearch.py - Last Failure

    Expand for error
     ConnectionTimeout caused by - ReadTimeoutError(HTTPConnectionPool(host='localhost', port=9200): Read timed out. (read timeout=10))
    
  • test_global_locks - test_threading.py - Last Failure

    Expand for error
     assert 4 == 2
      +  where 4 = len(deque([<ddtrace.profiling.collector.threading.ThreadingLockAcquireEvent object at 0x7fd57fd70e00>, <ddtrace.profiling.collector.threading.ThreadingLockAcquireEvent object at 0x7fd57fd70d60>, <ddtrace.profiling.collector.threading.ThreadingLockAcquireEvent object at 0x7fd57fd709a0>, <ddtrace.profiling.collector.threading.ThreadingLockAcquireEvent object at 0x7fd57fd711c0>]))
    

@pr-commenter
Copy link

pr-commenter bot commented Nov 28, 2024

Benchmarks

Benchmark execution time: 2024-11-28 18:39:36

Comparing candidate commit c78fba3 in PR branch backport-11580-to-2.11 with baseline commit 81e151f in branch 2.11.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

Copy link
Contributor Author

CODEOWNERS have been resolved as:

hatch.toml                                                              @DataDog/python-guild

@romainkomorndatadog romainkomorndatadog merged commit df51af7 into 2.11 Nov 29, 2024
184 of 189 checks passed
@romainkomorndatadog romainkomorndatadog deleted the backport-11580-to-2.11 branch November 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants