Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): improve iast startup time #11826

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Dec 23, 2024

Add these libraries to the IAST deny list:

  • numpy
  • allauth
  • celery
  • cv2
  • pydicom
  • nibabel
  • scipy
  • kombu
  • greenlet
  • redis
  • PIL
  • matplotlib
  • amqp

Migrate deny list to a regex

If a project imports all those libraries, the startup time benchmarks are:

main branch:

Start: December 23, 2024 - 11.45:11.363
End: December 23, 2024 - 11:45:40
Django version 5.0.6, using settings 'showcase.settings'
Starting development server at http://127.0.0.1:8000/
Quit the server with CONTROL-C.

TOTAL: 29s

This PR

Start: December 23, 2024 - 12.07:13.872
End: December 23, 2024 - 12:07:25
Django version 5.0.6, using settings 'showcase.settings'
Starting development server at http://127.0.0.1:8000/
Quit the server with CONTROL-C.

TOTAL: 12s

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Dec 23, 2024

CODEOWNERS have been resolved as:

scripts/iast/generate_import_exclusions_by_prefix.py                    @DataDog/asm-python
ddtrace/appsec/_iast/_ast/ast_patching.py                               @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 23, 2024

Benchmarks

Benchmark execution time: 2024-12-30 11:15:42

Comparing candidate commit 10af881 in PR branch avara1986/SCRS-1210_improve_iast_startup_time with baseline commit e472d5b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Dec 23, 2024
@avara1986 avara1986 force-pushed the avara1986/SCRS-1210_improve_iast_startup_time branch from aabf854 to 4747766 Compare December 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant