Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(profiling): ignore deprecated function tp_print warning #12045

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Jan 23, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner January 23, 2025 16:18
@taegyunkim taegyunkim added Profiling Continous Profling changelog/no-changelog A changelog entry is not required for this PR. labels Jan 23, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/crashtracker/CMakeLists.txt          @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/CMakeLists.txt                  @DataDog/profiling-python

Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! https://bugs.python.org/issue37250 (discussing deprecating/removing tp_print and breaking Cython builds) was quite an interesting read...

@taegyunkim taegyunkim enabled auto-merge (squash) January 23, 2025 17:01
@taegyunkim
Copy link
Contributor Author

Wonder whether this has to be backported or not, guess highly likely we need to?

@taegyunkim taegyunkim changed the title chore(profiling): ignore deprecated function tp_print warning ci(profiling): ignore deprecated function tp_print warning Jan 23, 2025
@nsrip-dd
Copy link
Contributor

Hmm... I think I'm actually missing a bit of context here. Did this recently start breaking? 3.8 has been out for a while, right? Did we change our Cython version or something?

@taegyunkim
Copy link
Contributor Author

Not sure either. It just became a problem out of nowhere. We don't pin Cython version, but looking at cython issues, this problem was there for a while.

@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2025

Benchmarks

Benchmark execution time: 2025-01-23 17:39:51

Comparing candidate commit a1ef77c in PR branch taegyunkim/cython-tp-print with baseline commit dc7037e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants