-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(profiling): ignore deprecated function tp_print
warning
#12045
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! https://bugs.python.org/issue37250 (discussing deprecating/removing tp_print and breaking Cython builds) was quite an interesting read...
Wonder whether this has to be backported or not, guess highly likely we need to? |
tp_print
warningtp_print
warning
Hmm... I think I'm actually missing a bit of context here. Did this recently start breaking? 3.8 has been out for a while, right? Did we change our Cython version or something? |
Not sure either. It just became a problem out of nowhere. We don't pin Cython version, but looking at cython issues, this problem was there for a while. |
BenchmarksBenchmark execution time: 2025-01-23 17:39:51 Comparing candidate commit a1ef77c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
Checklist
Reviewer Checklist