feat(provider): expose context provider in ddtrace.trace #12135

mabdinur · 2025-01-28T22:20:47Z

ddtrace v3.0 is set to remove ddtrace.providers module from the public API. However we should still allow users to use their own ContextProviders. This PR ensures the BaseContextProvider remains in the public API and can be used in tracer.configure(...).

Checklist

PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

datadog-dd-trace-py-rkomorn · 2025-01-28T22:44:18Z

Datadog Report

Branch report: munir/feat-expose-base-context-provider
Commit report: 0de1133
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 45.57s Total duration (35m 42.75s time saved)

pr-commenter · 2025-01-28T23:12:30Z

Benchmarks

Benchmark execution time: 2025-01-29 13:07:28

Comparing candidate commit 0de1133 in PR branch munir/feat-expose-base-context-provider with baseline commit c4448ea in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

.github/CODEOWNERS

fix codeowners

github-actions · 2025-01-28T23:45:23Z

CODEOWNERS have been resolved as:

releasenotes/notes/feat-expose-base-context-provider-530ebec2225f6c8d.yaml  @DataDog/apm-python
.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/provider.py                                                     @DataDog/apm-sdk-api-python
ddtrace/trace/__init__.py                                               @DataDog/apm-sdk-api-python
docs/advanced_usage.rst                                                 @DataDog/python-guild

ddtrace v3.0 is set to remove `ddtrace.providers` module from the public API. However we should still allow users to use their own ContextProviders. This PR ensures the BaseContextProvider remains in the public API and can be used in `tracer.configure(...)`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit cb41f8e)

ddtrace v3.0 is set to remove `ddtrace.providers` module from the public API. However we should still allow users to use their own ContextProviders. This PR ensures the BaseContextProvider remains in the public API and can be used in `tracer.configure(...)`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

…20] (#12137) Backport cb41f8e from #12135 to 2.20. ddtrace v3.0 is set to remove `ddtrace.providers` module from the public API. However we should still allow users to use their own ContextProviders. This PR ensures the BaseContextProvider remains in the public API and can be used in `tracer.configure(...)`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>

ddtrace v3.0 is set to remove `ddtrace.providers` module from the public API. However we should still allow users to use their own ContextProviders. This PR ensures the BaseContextProvider remains in the public API and can be used in `tracer.configure(...)`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit cb41f8e)

… 3.x] (#12155) Forwardporting #12135 ddtrace v3.0 is set to remove `ddtrace.providers` module from the public API. However we should still allow users to use their own ContextProviders. This PR ensures the BaseContextProvider remains in the public API and can be used in `tracer.configure(...)`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit cb41f8e) Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>

ddtrace v3.0 is set to remove `ddtrace.providers` module from the public API. However we should still allow users to use their own ContextProviders. This PR ensures the BaseContextProvider remains in the public API and can be used in `tracer.configure(...)`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

mabdinur requested review from a team as code owners January 28, 2025 22:20

mabdinur requested review from avara1986, duncanista and emmettbutler January 28, 2025 22:20

mabdinur force-pushed the munir/feat-expose-base-context-provider branch 3 times, most recently from b7cfd25 to 72376c3 Compare January 28, 2025 22:27

mabdinur changed the title ~~chore(provider): expose context provider in ddtrace.trace~~ feat(provider): expose context provider in ddtrace.trace Jan 28, 2025

mabdinur enabled auto-merge (squash) January 28, 2025 22:27

mabdinur force-pushed the munir/feat-expose-base-context-provider branch from 1dbc950 to 7f5744a Compare January 28, 2025 22:30

mabdinur requested a review from ZStriker19 January 28, 2025 22:39

mabdinur changed the base branch from main to 2.20 January 28, 2025 23:13

mabdinur requested review from a team as code owners January 28, 2025 23:13

mabdinur requested review from vitor-de-araujo and quinna-h January 28, 2025 23:13

mabdinur force-pushed the munir/feat-expose-base-context-provider branch from 7f5744a to 8a1dcd4 Compare January 28, 2025 23:14

mabdinur changed the title ~~feat(provider): expose context provider in ddtrace.trace~~ feat(provider): expose context provider in ddtrace.trace [targets 2.20] Jan 28, 2025

mabdinur changed the base branch from 2.20 to main January 28, 2025 23:15

mabdinur force-pushed the munir/feat-expose-base-context-provider branch from 8a1dcd4 to a37edfa Compare January 28, 2025 23:16

mabdinur changed the title ~~feat(provider): expose context provider in ddtrace.trace [targets 2.20]~~ feat(provider): expose context provider in ddtrace.trace Jan 28, 2025

mabdinur added the backport 2.20 label Jan 28, 2025

ZStriker19 approved these changes Jan 28, 2025

View reviewed changes

mabdinur commented Jan 28, 2025

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

DataDog deleted a comment from github-actions bot Jan 28, 2025

chore(provider): expose context provider in ddtrace.trace

331b712

fix codeowners

mabdinur force-pushed the munir/feat-expose-base-context-provider branch from 2dc7a6a to 331b712 Compare January 28, 2025 23:44

vitor-de-araujo approved these changes Jan 29, 2025

View reviewed changes

erikayasuda approved these changes Jan 29, 2025

View reviewed changes

Merge branch 'main' into munir/feat-expose-base-context-provider

0de1133

mabdinur merged commit cb41f8e into main Jan 29, 2025
635 checks passed

mabdinur deleted the munir/feat-expose-base-context-provider branch January 29, 2025 13:39

github-actions bot mentioned this pull request Jan 29, 2025

feat(provider): expose context provider in ddtrace.trace [backport 2.20] #12137

Merged

2 tasks

P403n1x87 mentioned this pull request Jan 29, 2025

chore(profiler): span link independent from context provider #11303

Draft

2 tasks

erikayasuda mentioned this pull request Jan 30, 2025

feat(provider): expose context provider in ddtrace.trace [forwardport 3.x] #12155

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(provider): expose context provider in ddtrace.trace #12135

feat(provider): expose context provider in ddtrace.trace #12135

mabdinur commented Jan 28, 2025 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Jan 28, 2025 •

edited

Loading

pr-commenter bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025

feat(provider): expose context provider in ddtrace.trace #12135

feat(provider): expose context provider in ddtrace.trace #12135

Conversation

mabdinur commented Jan 28, 2025 • edited Loading

Checklist

Reviewer Checklist

datadog-dd-trace-py-rkomorn bot commented Jan 28, 2025 • edited Loading

Datadog Report

pr-commenter bot commented Jan 28, 2025 • edited Loading

Benchmarks

github-actions bot commented Jan 28, 2025

mabdinur commented Jan 28, 2025 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Jan 28, 2025 •

edited

Loading

pr-commenter bot commented Jan 28, 2025 •

edited

Loading