Skip to content

Conversation

@gnufede
Copy link
Member

@gnufede gnufede commented Mar 19, 2025

CI Visibility: Remove code no longer used

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/ci_visibility/recorder.py                              @DataDog/ci-app-libraries
tests/ci_visibility/util.py                                             @DataDog/ci-app-libraries

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 237 ± 3 ms.

The average import time in main is: 238 ± 2 ms.

The import time difference between this PR and main is: -0.8 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.849 ms (0.78%)
ddtrace.bootstrap.sitecustomize 1.233 ms (0.52%)
ddtrace.bootstrap.preload 1.233 ms (0.52%)
ddtrace.internal.products 1.233 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.612 ms (0.26%)
ddtrace 0.616 ms (0.26%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2025

Benchmarks

Benchmark execution time: 2025-03-21 10:07:29

Comparing candidate commit 467add2 in PR branch gnufede/remove-recorder-do-request with baseline commit 23def5c in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 497 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathsplit_aspect

  • 🟩 execution_time [-373.577ns; -308.130ns] or [-8.755%; -7.221%]

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI App labels Mar 19, 2025
@gnufede gnufede force-pushed the gnufede/testopt-type-hinting-2 branch from 1b39096 to 1009655 Compare March 19, 2025 20:18
Base automatically changed from gnufede/testopt-type-hinting-2 to main March 19, 2025 21:12
@gnufede gnufede changed the title test chore(ci_visibility): remove code Mar 20, 2025
@gnufede gnufede marked this pull request as ready for review March 20, 2025 12:19
@gnufede gnufede requested a review from a team as a code owner March 20, 2025 12:19
@gnufede gnufede enabled auto-merge (squash) March 21, 2025 09:19
@gnufede gnufede merged commit 00c254b into main Mar 21, 2025
323 of 325 checks passed
@gnufede gnufede deleted the gnufede/remove-recorder-do-request branch March 21, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. CI App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants