Skip to content

Conversation

@taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Mar 21, 2025

Forgot to address this on #12672

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner March 21, 2025 19:22
@taegyunkim taegyunkim requested a review from emmettbutler March 21, 2025 19:22
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 21, 2025
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/smoke_test.py                                                     @DataDog/apm-core-python

@taegyunkim taegyunkim added the Profiling Continous Profling label Mar 21, 2025
@taegyunkim taegyunkim enabled auto-merge (squash) March 21, 2025 19:24
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 235 ± 2 ms.

The average import time in main is: 238 ± 3 ms.

The import time difference between this PR and main is: -2.9 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.028 ms (0.86%)
ddtrace.bootstrap.sitecustomize 1.325 ms (0.56%)
ddtrace.bootstrap.preload 1.325 ms (0.56%)
ddtrace.internal.products 1.325 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.645 ms (0.27%)
ddtrace 0.702 ms (0.30%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 21, 2025

Benchmarks

Benchmark execution time: 2025-03-25 14:44:51

Comparing candidate commit 3371e0a in PR branch taegyunkim/cp313-smoke-test with baseline commit 47d5913 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+369.186ns; +440.668ns] or [+7.283%; +8.693%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+305.537ns; +371.964ns] or [+7.788%; +9.481%]

@taegyunkim taegyunkim merged commit 8ff0057 into main Mar 25, 2025
833 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/cp313-smoke-test branch March 25, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants