Skip to content

Conversation

@taegyunkim
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/_threads.cpp                                           @DataDog/apm-core-python
ddtrace/internal/_threads.pyi                                           @DataDog/apm-core-python
tests/profiling_v2/collector/test_stack.py                              @DataDog/profiling-python

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 233 ± 3 ms.

The average import time from base is: 235 ± 3 ms.

The import time difference between this PR and base is: -1.1 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.930 ms (0.83%)
ddtrace.bootstrap.sitecustomize 1.261 ms (0.54%)
ddtrace.bootstrap.preload 1.261 ms (0.54%)
ddtrace.internal.products 1.261 ms (0.54%)
ddtrace.internal.remoteconfig.client 0.613 ms (0.26%)
ddtrace 0.669 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2025

Benchmarks

Benchmark execution time: 2025-04-23 20:47:38

Comparing candidate commit d0cdd0a in PR branch taegyunkim/stack-v2-ddtrace-threads with baseline commit 064f872 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 499 metrics, 8 unstable metrics.

scenario:iast_aspects-upper_aspect

  • 🟥 execution_time [+184.636ns; +238.177ns] or [+8.076%; +10.417%]

@github-actions github-actions bot added the stale label May 24, 2025
@github-actions
Copy link
Contributor

This pull request has been automatically closed after a period of inactivity.
After this much time, it will likely be easier to open a new pull request with the
same changes than to update this one from the base branch. Please comment or reopen
if you think this pull request was closed in error.

@github-actions github-actions bot closed this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants