Skip to content

Conversation

@smola
Copy link
Member

@smola smola commented Apr 21, 2025

Avoid setting lib_language tag explicitly on telemetry. This tag is automatically added to all telemetry data based on the HTTP header DD-Client-Library-Language.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Avoid setting `lib_language` tag explicitly on telemetry. This tag is
automatically added to all telemetry data based on the HTTP header
`DD-Client-Library-Language`.
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_metrics.py                                        @DataDog/asm-python
ddtrace/appsec/_metrics.py                                              @DataDog/asm-python
ddtrace/internal/telemetry/logging.py                                   @DataDog/apm-core-python

@smola smola added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Apr 21, 2025
@github-actions
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 233 ± 4 ms.

The average import time from base is: 239 ± 5 ms.

The import time difference between this PR and base is: -6.0 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.257 ms (0.97%)
ddtrace.bootstrap.sitecustomize 1.573 ms (0.67%)
ddtrace.bootstrap.preload 1.573 ms (0.67%)
ddtrace.internal.products 1.573 ms (0.67%)
ddtrace.internal.remoteconfig.client 0.695 ms (0.30%)
ddtrace 0.685 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 21, 2025

Benchmarks

Benchmark execution time: 2025-04-21 13:45:34

Comparing candidate commit 5110136 in PR branch smola/remove-redundant-temetry-tags with baseline commit 997a12e in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 471 metrics, 8 unstable metrics.

scenario:telemetryaddmetric-flush-1-metric

  • 🟥 execution_time [+352.410ns; +475.299ns] or [+8.190%; +11.046%]

@smola smola marked this pull request as ready for review April 21, 2025 14:13
@smola smola requested review from a team as code owners April 21, 2025 14:13
@smola smola requested a review from emmettbutler April 21, 2025 14:13
@smola smola enabled auto-merge (squash) April 21, 2025 14:31
@smola smola disabled auto-merge April 22, 2025 14:56
@smola smola changed the title chore(asm): remove redundant lib_language tag in telemetry chore(telemetry): remove redundant lib_language tag in telemetry Apr 22, 2025
@smola smola enabled auto-merge (squash) April 22, 2025 14:56
@smola smola merged commit 355dd87 into main Apr 22, 2025
409 of 410 checks passed
@smola smola deleted the smola/remove-redundant-temetry-tags branch April 22, 2025 16:32
brettlangdon pushed a commit that referenced this pull request May 6, 2025
)

Avoid setting `lib_language` tag explicitly on telemetry. This tag is
automatically added to all telemetry data based on the HTTP header
`DD-Client-Library-Language`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants