-
Notifications
You must be signed in to change notification settings - Fork 471
chore(ssi): improve telemetry submitted for ssi configurations #13249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tion was attempted on a host
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 232 ± 3 ms. The average import time from base is: 234 ± 2 ms. The import time difference between this PR and base is: -2.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-02 18:12:17 Comparing candidate commit 399e407 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 503 metrics, 5 unstable metrics. scenario:iast_aspects-ljust_aspect
scenario:iast_aspects-ospathnormcase_aspect
scenario:iast_aspects-ospathsplitdrive_aspect
scenario:iast_aspects-upper_aspect
|
bm1549
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending discussion on the doc
6ec00e5 to
d825e4a
Compare
b9039bc to
bd8ca4e
Compare
- Ensure `config._lib_was_injected` is set to `True` when SSI is successful. Currently this configuration is always set to `False` even when SSI is successful. - Use `DD_INJECTION_ENABLED` to track whether SSI was attempted. This env_var is set by the injector and is used by other SDKs. ## Checklist - [ ] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
config._lib_was_injectedis set toTruewhen SSI is successful. Currently this configuration is always set toFalseeven when SSI is successful.DD_INJECTION_ENABLEDto track whether SSI was attempted. This env_var is set by the injector and is used by other SDKs.Checklist
Reviewer Checklist