test: integration registry versioning #13298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| self, | ||
| integration_name: str, | ||
| is_external_package: bool = True, | ||
| dependency_names: list = [], |
Contributor
There was a problem hiding this comment.
🟠 Code Vulnerability
do not use a list `[]` as a default initializer in the function (...read more)
Developers should not be setting a default argument to an empty list. Instead, use None and check if the value is defined. Using a default list can cause unwanted behavior as the value of the argument is only evaluated once when the function is defined, not when it is run. Because of this, each function call will reference the same underlying memory when the default value is used, which can lead to unwanted behavior.
Learn More
| try: | ||
| os.remove(self.updater_lock_file_path) | ||
| except OSError: | ||
| pass |
Contributor
There was a problem hiding this comment.
🔴 Code Quality Violation
silent exception (...read more)
Using the pass statement in an exception block ignores the exception. Exceptions should never be ignored. Instead, the user must add code to notify an exception occurred and attempt to handle it or recover from it.
The exception to this rule is the use of StopIteration or StopAsyncIteration when implementing a custom iterator (as those errors are used to acknowledge the end of a successful iteration).
| try: | ||
| os.remove(data_file_path) | ||
| except OSError: | ||
| pass |
Contributor
There was a problem hiding this comment.
🔴 Code Quality Violation
silent exception (...read more)
Using the pass statement in an exception block ignores the exception. Exceptions should never be ignored. Instead, the user must add code to notify an exception occurred and attempt to handle it or recover from it.
The exception to this rule is the use of StopIteration or StopAsyncIteration when implementing a custom iterator (as those errors are used to acknowledge the end of a successful iteration).
Contributor
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 6 ms. The average import time from base is: 248 ± 8 ms. The import time difference between this PR and base is: 0.4 ± 0.3 ms. The difference is not statistically significant (z = 1.16). Import time breakdownThe following import paths have shrunk:
|
gnufede
changed the base branch from
main
to
conti/integration-registry-versioning
BenchmarksBenchmark execution time: 2025-04-30 12:33:12 Comparing candidate commit 7034567 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 499 metrics, 8 unstable metrics. scenario:iast_aspects-swapcase_aspect
|
wconti27
requested review from
avara1986 and
christophe-papazian
and removed request for
a team
wconti27
merged commit 8820b40
into
conti/integration-registry-versioning
684 of 705 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reviewer Checklist