Skip to content

Conversation

@cbeauchesne
Copy link
Contributor

@cbeauchesne cbeauchesne commented Apr 30, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/all-green.yml                                         @DataDog/python-guild @DataDog/apm-core-python

@cbeauchesne cbeauchesne added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 30, 2025
@cbeauchesne cbeauchesne changed the title do not run all-green job on pushes on main chore(ci): do not run all-green job on pushes on main Apr 30, 2025
@cbeauchesne cbeauchesne marked this pull request as ready for review April 30, 2025 14:43
@cbeauchesne cbeauchesne requested review from a team as code owners April 30, 2025 14:43
@cbeauchesne cbeauchesne enabled auto-merge (squash) April 30, 2025 14:43
@github-actions
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 230 ± 2 ms.

The average import time from base is: 232 ± 2 ms.

The import time difference between this PR and base is: -2.25 ± 0.07 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.988 ms (0.87%)
ddtrace.bootstrap.sitecustomize 1.320 ms (0.57%)
ddtrace.bootstrap.preload 1.320 ms (0.57%)
ddtrace.internal.products 1.320 ms (0.57%)
ddtrace.internal.remoteconfig.client 0.643 ms (0.28%)
ddtrace 0.668 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 30, 2025

Benchmarks

Benchmark execution time: 2025-04-30 15:26:39

Comparing candidate commit d09debd in PR branch cbeauchesne/all-green-correction with baseline commit b536794 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 506 metrics, 9 unstable metrics.

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+275.435ns; +354.742ns] or [+9.182%; +11.825%]

@cbeauchesne cbeauchesne merged commit 2765836 into main Apr 30, 2025
277 of 282 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/all-green-correction branch April 30, 2025 15:27
brettlangdon pushed a commit that referenced this pull request May 6, 2025
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants