-
Notifications
You must be signed in to change notification settings - Fork 469
chore(build): fix extension module hash calculation #14195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 287 ± 7 ms. The average import time from base is: 290 ± 8 ms. The import time difference between this PR and base is: -3.1 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: taegyunkim/ext-hash-glob (40befb0) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
On Python versions prior to 3.13, the following returns 0
Because
Path('.').rglob(**)returns only directories on older versions, but on Python 3.13 it returns all files and dirs.This resulted in incorrect computation for extension hashes
Checklist
Reviewer Checklist