chore(aap): improvements for django endpoint discovery #14280
Conversation
christophe-papazian
added
changelog/no-changelog
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 263 ± 1 ms. The average import time from base is: 265 ± 1 ms. The import time difference between this PR and base is: -1.83 ± 0.06 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: christophe-papazian/django_endpoint_discovery_improvements (fee9cd7) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
christophe-papazian
requested review from
avara1986,
brettlangdon and
quinna-h
brettlangdon
left a comment
brettlangdon
left a comment
There was a problem hiding this comment.
looks ok, I think having the dataclass for HttpEndPoint generate a hash function, or implementing one to compare method/path so we can use a set would be fewer changes/cleaner, but there isn't anything wrong with using a dict as you have it (not a blocker, feel free to disagree)
…nts' of github.com:DataDog/dd-trace-py into christophe-papazian/django_endpoint_discovery_improvements
christophe-papazian
deleted the
christophe-papazian/django_endpoint_discovery_improvements
branch
- ensure no endpoint (route, method) is send twice in the same payload - add threat test suite support for endpoint discovery and check for resource compatibility between telemetry payload and span attributes - minor test improvements APPSEC-58374 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- ensure no endpoint (route, method) is send twice in the same payload - add threat test suite support for endpoint discovery and check for resource compatibility between telemetry payload and span attributes - minor test improvements APPSEC-58374 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- ensure no endpoint (route, method) is send twice in the same payload - add threat test suite support for endpoint discovery and check for resource compatibility between telemetry payload and span attributes - minor test improvements APPSEC-58374 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
APPSEC-58374
Checklist
Reviewer Checklist