ci: fix inaccurate detect baseline script for benchmarks #14287
Conversation
ls-remote will use the provided string as a pattern, so when checking if the '3.12' branch exists, it'll allow anything that contains '3.12' in the name. this change is more exacting by checking for a specific ref instead
brettlangdon
added
the
changelog/no-changelog
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 277 ± 5 ms. The average import time from base is: 285 ± 5 ms. The import time difference between this PR and base is: -7.8 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: LANGPLAT-732/fix.detect.baseline (20d5f32) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
ls-remote will use the provided string as a pattern, so when checking if the '3.12' branch exists, it'll allow anything that contains '3.12' in the name. this change is more exacting by checking for a specific ref instead ``` UPSTREAM_BRANCH=v3.12.0rc1 + '[' v3.12.0rc1 == main ']' + [[ v3.12.0rc1 =~ ^v[0-9]+\.[0-9]+\.[0-9]+ ]] ++ echo 3.12.0rc1 ++ cut -d. -f1-2 + BASELINE_BRANCH=3.12 + git ls-remote --exit-code --heads origin 3.12 + echo 'Found remote branch origin/3.12' Found remote branch origin/3.12 ++ git describe --tags --abbrev=0 --exclude '*rc*' --exclude v3.12.0rc1 origin/3.12 fatal: Not a valid object name origin/3.12 ``` ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
ls-remote will use the provided string as a pattern, so when checking if the '3.12' branch exists, it'll allow anything that contains '3.12' in the name. this change is more exacting by checking for a specific ref instead ``` UPSTREAM_BRANCH=v3.12.0rc1 + '[' v3.12.0rc1 == main ']' + [[ v3.12.0rc1 =~ ^v[0-9]+\.[0-9]+\.[0-9]+ ]] ++ echo 3.12.0rc1 ++ cut -d. -f1-2 + BASELINE_BRANCH=3.12 + git ls-remote --exit-code --heads origin 3.12 + echo 'Found remote branch origin/3.12' Found remote branch origin/3.12 ++ git describe --tags --abbrev=0 --exclude '*rc*' --exclude v3.12.0rc1 origin/3.12 fatal: Not a valid object name origin/3.12 ``` ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
ls-remote will use the provided string as a pattern, so when checking if the '3.12' branch exists, it'll allow anything that contains '3.12' in the name. this change is more exacting by checking for a specific ref instead ``` UPSTREAM_BRANCH=v3.12.0rc1 + '[' v3.12.0rc1 == main ']' + [[ v3.12.0rc1 =~ ^v[0-9]+\.[0-9]+\.[0-9]+ ]] ++ echo 3.12.0rc1 ++ cut -d. -f1-2 + BASELINE_BRANCH=3.12 + git ls-remote --exit-code --heads origin 3.12 + echo 'Found remote branch origin/3.12' Found remote branch origin/3.12 ++ git describe --tags --abbrev=0 --exclude '*rc*' --exclude v3.12.0rc1 origin/3.12 fatal: Not a valid object name origin/3.12 ``` ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
ls-remote will use the provided string as a pattern, so when checking if the '3.12' branch exists, it'll allow anything that contains '3.12' in the name.
this change is more exacting by checking for a specific ref instead
Checklist
Reviewer Checklist