chore(codeowners): widen permissions for trace_handlers.py #14294
Conversation
brettlangdon
added
the
changelog/no-changelog
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 268 ± 2 ms. The average import time from base is: 269 ± 2 ms. The import time difference between this PR and base is: -1.0 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
mabdinur
left a comment
mabdinur
left a comment
There was a problem hiding this comment.
Looks good to me.
This is a separate issue but I think trace_handlers and trace_utils should live in the same directory. Either both in contrib or in _trace. My preference would be to move both to contrib since that's where they are used.
Performance SLOsCandidate: brettlangdon/codeowners.updates (c182871) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30🔵 No baseline data available for this suite ✅ 1-count-metric-1-timesTime: ✅ 3.618µs (SLO: <10.000µs 📉 -63.8%) Memory: ✅ 31.261MB (SLO: <34.000MB -8.1%) ✅ 1-count-metrics-100-timesTime: ✅ 223.655µs (SLO: <240.000µs -6.8%) Memory: ✅ 31.300MB (SLO: <34.000MB -7.9%) ✅ 1-distribution-metric-1-timesTime: ✅ 3.444µs (SLO: <10.000µs 📉 -65.6%) Memory: ✅ 31.261MB (SLO: <34.000MB -8.1%) ✅ 1-distribution-metrics-100-timesTime: ✅ 198.407µs (SLO: <210.000µs -5.5%) Memory: ✅ 31.359MB (SLO: <34.000MB -7.8%) ✅ 1-gauge-metric-1-timesTime: ✅ 2.074µs (SLO: <10.000µs 📉 -79.3%) Memory: ✅ 31.320MB (SLO: <34.000MB -7.9%) ✅ 1-gauge-metrics-100-timesTime: ✅ 125.506µs (SLO: <140.000µs 📉 -10.4%) Memory: ✅ 31.300MB (SLO: <34.000MB -7.9%) ✅ 1-rate-metric-1-timesTime: ✅ 3.160µs (SLO: <10.000µs 📉 -68.4%) Memory: ✅ 31.241MB (SLO: <34.000MB -8.1%) ✅ 1-rate-metrics-100-timesTime: ✅ 226.463µs (SLO: <230.000µs 🟡 -1.5%) Memory: ✅ 31.339MB (SLO: <34.000MB -7.8%) ❌ 100-count-metrics-100-timesTime: ❌ 22.795ms (SLO: <22.500ms +1.3%) Memory: ✅ 31.379MB (SLO: <34.000MB -7.7%) ✅ 100-distribution-metrics-100-timesTime: ✅ 2.105ms (SLO: <2.100ms +0.3%) Memory: ✅ 31.202MB (SLO: <34.000MB -8.2%) ✅ 100-gauge-metrics-100-timesTime: ✅ 1.283ms (SLO: <1.400ms -8.4%) Memory: ✅ 31.182MB (SLO: <34.000MB -8.3%) ✅ 100-rate-metrics-100-timesTime: ✅ 2.251ms (SLO: <2.400ms -6.2%) Memory: ✅ 31.261MB (SLO: <34.000MB -8.1%) ✅ flush-1-metricTime: ✅ 4.690µs (SLO: <10.000µs 📉 -53.1%) Memory: ✅ 31.280MB (SLO: <34.000MB -8.0%) ✅ flush-100-metricsTime: ✅ 184.008µs (SLO: <200.000µs -8.0%) Memory: ✅ 31.280MB (SLO: <34.000MB -8.0%) ✅ flush-1000-metricsTime: ✅ 2.214ms (SLO: <2.350ms -5.8%) Memory: ✅ 32.519MB (SLO: <34.500MB -5.7%) 🔵 No Baseline Data (23 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
Right now updating an integration which uses the core api may also be blocked on the sdk team since the integration handlers to convert core events into spans lives in `ddtrace/_trace/`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Right now updating an integration which uses the core api may also be blocked on the sdk team since the integration handlers to convert core events into spans lives in `ddtrace/_trace/`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Right now updating an integration which uses the core api may also be blocked on the sdk team since the integration handlers to convert core events into spans lives in `ddtrace/_trace/`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Right now updating an integration which uses the core api may also be blocked on the sdk team since the integration handlers to convert core events into spans lives in `ddtrace/_trace/`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Right now updating an integration which uses the core api may also be blocked on the sdk team since the integration handlers to convert core events into spans lives in
ddtrace/_trace/.Checklist
Reviewer Checklist