Skip to content

Conversation

@dd-octo-sts
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Aug 18, 2025

Backport bea1bd2 from #14329 to 3.10.

Signed-off-by: Juanjo Alvarez juanjo.alvarezmartinez@datadoghq.com## Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>##
Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Signed-off-by: Juanjo Alvarez
<juanjo.alvarezmartinez@datadoghq.com>Signed-off-by: Juanjo Alvarez
<juanjo.alvarezmartinez@datadoghq.com>Signed-off-by: Juanjo Alvarez
<juanjo.alvarezmartinez@datadoghq.com>Signed-off-by: Juanjo Alvarez
<juanjo.alvarezmartinez@datadoghq.com>

---------

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
(cherry picked from commit bea1bd2)
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@dd-octo-sts dd-octo-sts bot requested review from a team as code owners August 18, 2025 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/circular-psycopg3-import-c27df66875895fc7.yaml       @DataDog/apm-python
tests/contrib/psycopg2/fixtures/__init__.py                             @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg2/fixtures/reproduce_psycopg_cyclic_import_error.py  @DataDog/apm-core-python @DataDog/apm-idm-python
.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/contrib/internal/psycopg/patch.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg/test_psycopg_patch.py                             @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg2/test_psycopg_patch.py                            @DataDog/apm-core-python @DataDog/apm-idm-python

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 283 ± 4 ms.

The average import time from base is: 287 ± 4 ms.

The import time difference between this PR and base is: -4.7 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.155 ms (0.76%)
ddtrace.bootstrap.sitecustomize 1.474 ms (0.52%)
ddtrace.bootstrap.preload 1.474 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.701 ms (0.25%)
ddtrace 0.681 ms (0.24%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Aug 18, 2025

Benchmarks

Benchmark execution time: 2025-08-19 11:49:37

Comparing candidate commit e458882 in PR branch backport-14329-to-3.10 with baseline commit b4717cc in branch 3.10.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 540 metrics, 3 unstable metrics.

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+342.654ns; +497.997ns] or [+9.732%; +14.144%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+587.539ns; +651.717ns] or [+15.942%; +17.684%]

scenario:iastaspectsospath-ospathsplitext_aspect

  • 🟥 execution_time [+810.486ns; +880.528ns] or [+17.822%; +19.362%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+155.518ns; +211.327ns] or [+10.669%; +14.498%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+269.303ns; +357.670ns] or [+8.595%; +11.415%]

scenario:telemetryaddmetric-1-gauge-metric-1-times

  • 🟥 execution_time [+218.205ns; +283.793ns] or [+10.381%; +13.501%]

scenario:telemetryaddmetric-1-rate-metric-1-times

  • 🟥 execution_time [+301.390ns; +376.276ns] or [+9.544%; +11.915%]

@juanjux juanjux force-pushed the backport-14329-to-3.10 branch from 93df808 to f1b35c0 Compare August 19, 2025 09:38
@juanjux juanjux enabled auto-merge (squash) August 19, 2025 09:38
@juanjux juanjux requested a review from a team as a code owner August 19, 2025 09:55
@juanjux juanjux merged commit e5b0b64 into 3.10 Aug 19, 2025
411 checks passed
@juanjux juanjux deleted the backport-14329-to-3.10 branch August 19, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants