chore(asgi): refactor websocket code to use core API #14345

quinna-h · 2025-08-18T21:47:56Z

In asgi middleware:

move tracing logic to trace handlers
refactor out websocket.receive and websocket.disconnect messages to call respective trace handlers
refactor out websocket.send and websocket.close messages to call respective trace handlers

Checklist

PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions · 2025-08-18T21:48:30Z

CODEOWNERS have been resolved as:

ddtrace/_trace/trace_handlers.py                                        @DataDog/apm-sdk-capabilities-python @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/asgi/middleware.py                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/internal/sampling.py                                            @DataDog/apm-sdk-capabilities-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_long_running_websocket_session.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_traced_websocket.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_websocket_only_sends.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_websocket_tracing_not_separate_traces.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_websocket_tracing_sampling_not_inherited.json  @DataDog/apm-python

github-actions · 2025-08-18T22:12:48Z

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 242 ± 3 ms.

The average import time from base is: 243 ± 3 ms.

The import time difference between this PR and base is: -1.0 ± 0.1 ms.

Import time breakdown

The following import paths have appeared:

ddtrace.auto 0.235 ms (0.10%)

ddtrace.bootstrap.sitecustomize 0.235 ms (0.10%)

ddtrace._trace.trace_handlers 0.235 ms (0.10%)

ddtrace.ext.websocket 0.235 ms (0.10%)

The following import paths have grown:

ddtrace.auto 0.849 ms (0.35%)

ddtrace.bootstrap.sitecustomize 0.849 ms (0.35%)

ddtrace._trace.trace_handlers 0.080 ms (0.03%)

The following import paths have shrunk:

ddtrace.auto 2.659 ms (1.10%)

ddtrace.bootstrap.sitecustomize 1.984 ms (0.82%)

ddtrace.bootstrap.preload 1.263 ms (0.52%)

ddtrace.internal.remoteconfig.client 0.619 ms (0.26%)

shlex 0.721 ms (0.30%)

ddtrace 0.676 ms (0.28%)

ddtrace.internal._unpatched 0.031 ms (0.01%)

json 0.031 ms (0.01%)

json.decoder 0.031 ms (0.01%)

re 0.031 ms (0.01%)

enum 0.031 ms (0.01%)

types 0.031 ms (0.01%)

pr-commenter · 2025-08-18T23:05:18Z

Performance SLOs

Comparing candidate refactor-asgi-core-api (ce2ccb4) with baseline main (967ff6d)

📈 Performance Regressions (1 suite)

📈 iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.7%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ add_inplace_aspect

Time: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.2%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ add_inplace_noaspect

Time: ✅ 0.323µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +1.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ add_noaspect

Time: ✅ 0.275µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -1.9%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ bytearray_aspect

Time: ✅ 1.343µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.8%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ bytearray_extend_aspect

Time: ✅ 1.512µs (SLO: <10.000µs 📉 -84.9%) vs baseline: -0.7%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ bytearray_extend_noaspect

Time: ✅ 0.617µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.6%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ bytearray_noaspect

Time: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -1.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ bytes_aspect

Time: ✅ 1.314µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +1.7%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ bytes_noaspect

Time: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ bytesio_aspect

Time: ✅ 1.364µs (SLO: <10.000µs 📉 -86.4%) vs baseline: -0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ bytesio_noaspect

Time: ✅ 0.500µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.4%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ capitalize_aspect

Time: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ capitalize_noaspect

Time: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.9%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.0%

✅ casefold_aspect

Time: ✅ 0.732µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ casefold_noaspect

Time: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.8%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ decode_aspect

Time: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.7%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ decode_noaspect

Time: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.3%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6%

✅ encode_aspect

Time: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6%

✅ encode_noaspect

Time: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ format_aspect

Time: ✅ 3.549µs (SLO: <10.000µs 📉 -64.5%) vs baseline: +5.5%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ format_map_aspect

Time: ✅ 3.607µs (SLO: <10.000µs 📉 -63.9%) vs baseline: +0.7%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ format_map_noaspect

Time: ✅ 0.782µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ format_noaspect

Time: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.6%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ index_aspect

Time: ✅ 0.364µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.5%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ index_noaspect

Time: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.2%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ join_aspect

Time: ✅ 1.353µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ join_noaspect

Time: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.0%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ ljust_aspect

Time: ✅ 2.707µs (SLO: <20.000µs 📉 -86.5%) vs baseline: +5.7%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ ljust_noaspect

Time: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ lower_aspect

Time: ✅ 2.335µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +6.4%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ lower_noaspect

Time: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.8%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ lstrip_aspect

Time: ✅ 2.518µs (SLO: <20.000µs 📉 -87.4%) vs baseline: 📈 +14.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ lstrip_noaspect

Time: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.3%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ modulo_aspect

Time: ✅ 0.994µs (SLO: <10.000µs 📉 -90.1%) vs baseline: -0.4%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.8%

✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.594µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +3.4%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ modulo_aspect_for_bytes

Time: ✅ 0.980µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.262µs (SLO: <10.000µs 📉 -87.4%) vs baseline: +2.7%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.8%

✅ modulo_noaspect

Time: ✅ 0.626µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.3%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ replace_aspect

Time: ✅ 5.432µs (SLO: <10.000µs 📉 -45.7%) vs baseline: 📈 +12.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ replace_noaspect

Time: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.9%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ repr_aspect

Time: ✅ 0.903µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ repr_noaspect

Time: ✅ 0.423µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +2.1%

Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +4.5%

✅ rstrip_aspect

Time: ✅ 2.043µs (SLO: <20.000µs 📉 -89.8%) vs baseline: +7.9%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ rstrip_noaspect

Time: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.8%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1%

✅ slice_aspect

Time: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same

Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.5%

✅ slice_noaspect

Time: ✅ 0.447µs (SLO: <10.000µs 📉 -95.5%) vs baseline: ~same

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ stringio_aspect

Time: ✅ 1.764µs (SLO: <10.000µs 📉 -82.4%) vs baseline: 📈 +12.3%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ stringio_noaspect

Time: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.8%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1%

✅ strip_aspect

Time: ✅ 2.502µs (SLO: <20.000µs 📉 -87.5%) vs baseline: 📈 +14.7%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ strip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ swapcase_aspect

Time: ✅ 2.413µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +0.6%

Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.8%

✅ swapcase_noaspect

Time: ✅ 0.541µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +1.3%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ title_aspect

Time: ✅ 2.434µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +5.5%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ title_noaspect

Time: ✅ 0.506µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +1.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ translate_aspect

Time: ✅ 3.251µs (SLO: <10.000µs 📉 -67.5%) vs baseline: +0.3%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ translate_noaspect

Time: ✅ 1.038µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.2%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ upper_aspect

Time: ✅ 2.383µs (SLO: <10.000µs 📉 -76.2%) vs baseline: +8.8%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7%

✅ upper_noaspect

Time: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

🟡 Near SLO Breach (4 suites)

🟡 djangosimple - 30/30

✅ appsec

Time: ✅ 20.496ms (SLO: <22.300ms -8.1%) vs baseline: +0.1%

Memory: ✅ 65.352MB (SLO: <67.000MB -2.5%) vs baseline: +4.5%

✅ exception-replay-enabled

Time: ✅ 1.342ms (SLO: <1.450ms -7.4%) vs baseline: -0.2%

Memory: ✅ 64.516MB (SLO: <67.000MB -3.7%) vs baseline: +4.9%

✅ iast

Time: ✅ 20.423ms (SLO: <22.250ms -8.2%) vs baseline: -0.2%

Memory: ✅ 65.303MB (SLO: <67.000MB -2.5%) vs baseline: +4.5%

✅ profiler

Time: ✅ 15.235ms (SLO: <16.550ms -7.9%) vs baseline: +0.2%

Memory: ✅ 53.727MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +5.0%

✅ resource-renaming

Time: ✅ 20.498ms (SLO: <21.750ms -5.8%) vs baseline: -0.4%

Memory: ✅ 65.333MB (SLO: <67.000MB -2.5%) vs baseline: +4.6%

✅ span-code-origin

Time: ✅ 26.196ms (SLO: <28.200ms -7.1%) vs baseline: +0.2%

Memory: ✅ 68.122MB (SLO: <69.500MB 🟡 -2.0%) vs baseline: +4.6%

✅ tracer

Time: ✅ 20.485ms (SLO: <21.750ms -5.8%) vs baseline: -0.2%

Memory: ✅ 65.303MB (SLO: <67.000MB -2.5%) vs baseline: +4.4%

✅ tracer-and-profiler

Time: ✅ 22.019ms (SLO: <23.500ms -6.3%) vs baseline: +0.2%

Memory: ✅ 66.761MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.2%

✅ tracer-dont-create-db-spans

Time: ✅ 19.285ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.2%

Memory: ✅ 65.411MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.6%

✅ tracer-minimal

Time: ✅ 16.563ms (SLO: <17.500ms -5.4%) vs baseline: -0.5%

Memory: ✅ 65.352MB (SLO: <66.000MB 🟡 -1.0%) vs baseline: +5.1%

✅ tracer-native

Time: ✅ 20.505ms (SLO: <21.750ms -5.7%) vs baseline: +0.2%

Memory: ✅ 71.235MB (SLO: <72.500MB 🟡 -1.7%) vs baseline: +4.7%

✅ tracer-no-caches

Time: ✅ 18.401ms (SLO: <19.650ms -6.4%) vs baseline: ~same

Memory: ✅ 65.298MB (SLO: <67.000MB -2.5%) vs baseline: +4.6%

✅ tracer-no-databases

Time: ✅ 18.746ms (SLO: <20.100ms -6.7%) vs baseline: ~same

Memory: ✅ 65.304MB (SLO: <67.000MB -2.5%) vs baseline: +5.1%

✅ tracer-no-middleware

Time: ✅ 20.181ms (SLO: <21.500ms -6.1%) vs baseline: ~same

Memory: ✅ 65.329MB (SLO: <67.000MB -2.5%) vs baseline: +4.8%

✅ tracer-no-templates

Time: ✅ 20.348ms (SLO: <22.000ms -7.5%) vs baseline: +0.2%

Memory: ✅ 65.382MB (SLO: <67.000MB -2.4%) vs baseline: +4.5%

🟡 errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 18.058ms (SLO: <19.850ms -9.0%) vs baseline: +0.2%

Memory: ✅ 65.333MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9%

✅ errortracking-enabled-user

Time: ✅ 18.150ms (SLO: <19.400ms -6.4%) vs baseline: +0.4%

Memory: ✅ 65.294MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.8%

✅ tracer-enabled

Time: ✅ 18.131ms (SLO: <19.450ms -6.8%) vs baseline: +0.4%

Memory: ✅ 65.392MB (SLO: <66.500MB 🟡 -1.7%) vs baseline: +5.1%

🟡 flasksimple - 18/18

✅ appsec-get

Time: ✅ 4.559ms (SLO: <4.750ms -4.0%) vs baseline: -0.6%

Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +4.7%

✅ appsec-post

Time: ✅ 6.558ms (SLO: <6.750ms -2.8%) vs baseline: ~same

Memory: ✅ 61.892MB (SLO: <65.000MB -4.8%) vs baseline: +4.8%

✅ appsec-telemetry

Time: ✅ 4.554ms (SLO: <4.750ms -4.1%) vs baseline: -0.4%

Memory: ✅ 61.892MB (SLO: <65.000MB -4.8%) vs baseline: +4.8%

✅ debugger

Time: ✅ 1.851ms (SLO: <2.000ms -7.4%) vs baseline: -0.4%

Memory: ✅ 45.377MB (SLO: <47.000MB -3.5%) vs baseline: +4.6%

✅ iast-get

Time: ✅ 1.861ms (SLO: <2.000ms -6.9%) vs baseline: -0.6%

Memory: ✅ 42.310MB (SLO: <49.000MB 📉 -13.7%) vs baseline: +4.7%

✅ profiler

Time: ✅ 1.910ms (SLO: <2.100ms -9.0%) vs baseline: +0.1%

Memory: ✅ 46.458MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.7%

✅ resource-renaming

Time: ✅ 3.379ms (SLO: <3.650ms -7.4%) vs baseline: +0.3%

Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9%

✅ tracer

Time: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: -0.2%

Memory: ✅ 52.160MB (SLO: <53.500MB -2.5%) vs baseline: +4.7%

✅ tracer-native

Time: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: ~same

Memory: ✅ 58.118MB (SLO: <60.000MB -3.1%) vs baseline: +5.1%

🟡 otelspan - 22/22

✅ add-event

Time: ✅ 45.222ms (SLO: <47.150ms -4.1%) vs baseline: +0.2%

Memory: ✅ 45.264MB (SLO: <47.000MB -3.7%) vs baseline: +4.7%

✅ add-metrics

Time: ✅ 321.864ms (SLO: <344.800ms -6.7%) vs baseline: +0.7%

Memory: ✅ 552.497MB (SLO: <562.000MB 🟡 -1.7%) vs baseline: +4.9%

✅ add-tags

Time: ✅ 291.955ms (SLO: <314.000ms -7.0%) vs baseline: -0.3%

Memory: ✅ 553.656MB (SLO: <563.500MB 🟡 -1.7%) vs baseline: +4.7%

✅ get-context

Time: ✅ 82.916ms (SLO: <92.350ms 📉 -10.2%) vs baseline: +0.3%

Memory: ✅ 40.271MB (SLO: <46.500MB 📉 -13.4%) vs baseline: +5.0%

✅ is-recording

Time: ✅ 42.942ms (SLO: <44.500ms -3.5%) vs baseline: +0.1%

Memory: ✅ 44.599MB (SLO: <47.500MB -6.1%) vs baseline: +4.8%

✅ record-exception

Time: ✅ 61.653ms (SLO: <67.650ms -8.9%) vs baseline: ~same

Memory: ✅ 40.634MB (SLO: <47.000MB 📉 -13.5%) vs baseline: +5.0%

✅ set-status

Time: ✅ 48.809ms (SLO: <50.400ms -3.2%) vs baseline: +0.9%

Memory: ✅ 44.654MB (SLO: <47.000MB -5.0%) vs baseline: +4.9%

✅ start

Time: ✅ 42.087ms (SLO: <43.450ms -3.1%) vs baseline: +0.3%

Memory: ✅ 44.625MB (SLO: <47.000MB -5.1%) vs baseline: +4.7%

✅ start-finish

Time: ✅ 83.181ms (SLO: <88.000ms -5.5%) vs baseline: +0.6%

Memory: ✅ 34.603MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.8%

✅ start-finish-telemetry

Time: ✅ 84.824ms (SLO: <89.000ms -4.7%) vs baseline: +0.4%

Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.6%

✅ update-name

Time: ✅ 44.053ms (SLO: <45.150ms -2.4%) vs baseline: -0.4%

Memory: ✅ 45.001MB (SLO: <47.000MB -4.3%) vs baseline: +4.9%

⚠️ Unstable Tests (1 suite)

⚠️

coreapiscenario - 10/10 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.274µs (SLO: <20.000µs 📉 -33.6%) vs baseline: +0.1%

Memory: ✅ 32.106MB (SLO: <33.500MB -4.2%) vs baseline: +4.9%

✅ context_with_data_no_listeners

Time: ✅ 3.250µs (SLO: <10.000µs 📉 -67.5%) vs baseline: -0.3%

Memory: ✅ 32.086MB (SLO: <33.500MB -4.2%) vs baseline: +4.7%

✅ get_item_exists

Time: ✅ 0.582µs (SLO: <10.000µs 📉 -94.2%) vs baseline: ~same

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +5.1%

✅ get_item_missing

Time: ✅ 0.638µs (SLO: <10.000µs 📉 -93.6%) vs baseline: +1.2%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.1%

✅ set_item

Time: ✅ 24.216µs (SLO: <30.000µs 📉 -19.3%) vs baseline: +1.5%

Memory: ✅ 32.106MB (SLO: <33.500MB -4.2%) vs baseline: +5.3%

✅ All Tests Passing (18 suites)

✅ errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.082ms (SLO: <2.300ms -9.5%) vs baseline: +0.2%

Memory: ✅ 52.180MB (SLO: <53.500MB -2.5%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 2.095ms (SLO: <2.250ms -6.9%) vs baseline: +0.9%

Memory: ✅ 52.219MB (SLO: <53.500MB -2.4%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 2.082ms (SLO: <2.300ms -9.5%) vs baseline: +0.3%

Memory: ✅ 52.199MB (SLO: <53.500MB -2.4%) vs baseline: +4.7%

✅ flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.913ms (SLO: <4.200ms -6.8%) vs baseline: ~same

Memory: ✅ 62.148MB (SLO: <66.000MB -5.8%) vs baseline: +4.8%

✅ iast-enabled

Time: ✅ 2.440ms (SLO: <2.800ms 📉 -12.8%) vs baseline: +0.2%

Memory: ✅ 58.648MB (SLO: <60.000MB -2.3%) vs baseline: +4.8%

✅ tracer-enabled

Time: ✅ 2.070ms (SLO: <2.250ms -8.0%) vs baseline: -0.2%

Memory: ✅ 52.239MB (SLO: <54.500MB -4.1%) vs baseline: +4.9%

✅ httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 81.512µs (SLO: <100.000µs 📉 -18.5%) vs baseline: +0.8%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ b3_headers

Time: ✅ 14.939µs (SLO: <20.000µs 📉 -25.3%) vs baseline: +4.8%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ b3_single_headers

Time: ✅ 14.316µs (SLO: <20.000µs 📉 -28.4%) vs baseline: +7.3%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 63.361µs (SLO: <80.000µs 📉 -20.8%) vs baseline: ~same

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 67.433µs (SLO: <80.000µs 📉 -15.7%) vs baseline: +2.8%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ empty_headers

Time: ✅ 1.595µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.2%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ full_t_id_datadog_headers

Time: ✅ 24.236µs (SLO: <30.000µs 📉 -19.2%) vs baseline: +7.5%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ invalid_priority_header

Time: ✅ 6.569µs (SLO: <10.000µs 📉 -34.3%) vs baseline: +1.5%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ invalid_span_id_header

Time: ✅ 6.581µs (SLO: <10.000µs 📉 -34.2%) vs baseline: +1.5%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ invalid_tags_header

Time: ✅ 6.514µs (SLO: <10.000µs 📉 -34.9%) vs baseline: -0.4%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ invalid_trace_id_header

Time: ✅ 6.638µs (SLO: <10.000µs 📉 -33.6%) vs baseline: +1.6%

Memory: ✅ 32.047MB (SLO: <33.500MB -4.3%) vs baseline: +4.4%

✅ large_header_no_matches

Time: ✅ 27.698µs (SLO: <30.000µs -7.7%) vs baseline: +0.6%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ large_valid_headers_all

Time: ✅ 28.610µs (SLO: <40.000µs 📉 -28.5%) vs baseline: ~same

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ medium_header_no_matches

Time: ✅ 9.846µs (SLO: <20.000µs 📉 -50.8%) vs baseline: -0.3%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ medium_valid_headers_all

Time: ✅ 11.316µs (SLO: <20.000µs 📉 -43.4%) vs baseline: +0.7%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ none_propagation_style

Time: ✅ 1.681µs (SLO: <10.000µs 📉 -83.2%) vs baseline: -0.6%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.9%

✅ tracecontext_headers

Time: ✅ 36.071µs (SLO: <40.000µs -9.8%) vs baseline: +5.0%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.6%

✅ valid_headers_all

Time: ✅ 6.629µs (SLO: <10.000µs 📉 -33.7%) vs baseline: +1.5%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.6%

✅ valid_headers_basic

Time: ✅ 6.065µs (SLO: <10.000µs 📉 -39.3%) vs baseline: ~same

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ wsgi_empty_headers

Time: ✅ 1.603µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.5%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.1%

✅ wsgi_invalid_priority_header

Time: ✅ 6.639µs (SLO: <10.000µs 📉 -33.6%) vs baseline: +1.6%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ wsgi_invalid_span_id_header

Time: ✅ 1.591µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.9%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_invalid_tags_header

Time: ✅ 6.521µs (SLO: <10.000µs 📉 -34.8%) vs baseline: -0.5%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.2%

✅ wsgi_invalid_trace_id_header

Time: ✅ 6.633µs (SLO: <10.000µs 📉 -33.7%) vs baseline: +0.5%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_large_header_no_matches

Time: ✅ 28.862µs (SLO: <40.000µs 📉 -27.8%) vs baseline: +0.2%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ wsgi_large_valid_headers_all

Time: ✅ 29.941µs (SLO: <40.000µs 📉 -25.1%) vs baseline: +0.1%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ wsgi_medium_header_no_matches

Time: ✅ 10.174µs (SLO: <20.000µs 📉 -49.1%) vs baseline: -0.2%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.531µs (SLO: <20.000µs 📉 -42.3%) vs baseline: -1.6%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.8%

✅ wsgi_valid_headers_all

Time: ✅ 6.628µs (SLO: <10.000µs 📉 -33.7%) vs baseline: +1.5%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ wsgi_valid_headers_basic

Time: ✅ 6.050µs (SLO: <10.000µs 📉 -39.5%) vs baseline: -0.7%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ httppropagationinject - 16/16

✅ ids_only

Time: ✅ 21.761µs (SLO: <30.000µs 📉 -27.5%) vs baseline: -0.1%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.9%

✅ with_all

Time: ✅ 29.584µs (SLO: <40.000µs 📉 -26.0%) vs baseline: +1.5%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.8%

✅ with_dd_origin

Time: ✅ 25.619µs (SLO: <30.000µs 📉 -14.6%) vs baseline: +1.0%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ with_priority_and_origin

Time: ✅ 25.836µs (SLO: <40.000µs 📉 -35.4%) vs baseline: +4.5%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ with_sampling_priority

Time: ✅ 21.753µs (SLO: <30.000µs 📉 -27.5%) vs baseline: +0.8%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ with_tags

Time: ✅ 28.351µs (SLO: <40.000µs 📉 -29.1%) vs baseline: +5.2%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ with_tags_invalid

Time: ✅ 28.532µs (SLO: <40.000µs 📉 -28.7%) vs baseline: -0.1%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ with_tags_max_size

Time: ✅ 27.735µs (SLO: <40.000µs 📉 -30.7%) vs baseline: +0.9%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 31.968µs (SLO: <40.000µs 📉 -20.1%) vs baseline: +0.3%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_expand_noaspect

Time: ✅ 28.383µs (SLO: <40.000µs 📉 -29.0%) vs baseline: -1.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ re_findall_aspect

Time: ✅ 2.889µs (SLO: <10.000µs 📉 -71.1%) vs baseline: -0.9%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ re_findall_noaspect

Time: ✅ 1.409µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -1.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ re_finditer_aspect

Time: ✅ 4.421µs (SLO: <10.000µs 📉 -55.8%) vs baseline: -0.4%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ re_finditer_noaspect

Time: ✅ 1.418µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.1%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_fullmatch_aspect

Time: ✅ 2.701µs (SLO: <10.000µs 📉 -73.0%) vs baseline: +1.1%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ re_fullmatch_noaspect

Time: ✅ 1.296µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.7%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ re_group_aspect

Time: ✅ 2.972µs (SLO: <10.000µs 📉 -70.3%) vs baseline: +0.7%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ re_group_noaspect

Time: ✅ 1.611µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.4%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ re_groups_aspect

Time: ✅ 3.099µs (SLO: <10.000µs 📉 -69.0%) vs baseline: +0.5%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ re_groups_noaspect

Time: ✅ 1.712µs (SLO: <10.000µs 📉 -82.9%) vs baseline: +0.9%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.5%

✅ re_match_aspect

Time: ✅ 2.743µs (SLO: <10.000µs 📉 -72.6%) vs baseline: +1.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ re_match_noaspect

Time: ✅ 1.297µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -1.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ re_search_aspect

Time: ✅ 2.589µs (SLO: <10.000µs 📉 -74.1%) vs baseline: +1.1%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ re_search_noaspect

Time: ✅ 1.202µs (SLO: <10.000µs 📉 -88.0%) vs baseline: -0.9%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ re_sub_aspect

Time: ✅ 3.395µs (SLO: <10.000µs 📉 -66.1%) vs baseline: -0.7%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1%

✅ re_sub_noaspect

Time: ✅ 1.540µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -0.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ re_subn_aspect

Time: ✅ 3.682µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +1.5%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ re_subn_noaspect

Time: ✅ 1.611µs (SLO: <10.000µs 📉 -83.9%) vs baseline: -0.8%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.183µs (SLO: <10.000µs 📉 -58.2%) vs baseline: +0.8%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ ospathbasename_noaspect

Time: ✅ 1.077µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -1.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ ospathjoin_aspect

Time: ✅ 6.655µs (SLO: <10.000µs 📉 -33.5%) vs baseline: +9.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ ospathjoin_noaspect

Time: ✅ 2.298µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.3%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7%

✅ ospathnormcase_aspect

Time: ✅ 3.463µs (SLO: <10.000µs 📉 -65.4%) vs baseline: +1.0%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ ospathnormcase_noaspect

Time: ✅ 0.565µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -2.0%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ ospathsplit_aspect

Time: ✅ 4.737µs (SLO: <10.000µs 📉 -52.6%) vs baseline: +1.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ ospathsplit_noaspect

Time: ✅ 1.595µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.2%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ ospathsplitdrive_aspect

Time: ✅ 3.640µs (SLO: <10.000µs 📉 -63.6%) vs baseline: -0.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6%

✅ ospathsplitdrive_noaspect

Time: ✅ 0.696µs (SLO: <10.000µs 📉 -93.0%) vs baseline: ~same

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ ospathsplitext_aspect

Time: ✅ 4.510µs (SLO: <10.000µs 📉 -54.9%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ ospathsplitext_noaspect

Time: ✅ 1.380µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -1.2%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.393µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.8%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ rsplit_noaspect

Time: ✅ 0.584µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.4%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ split_aspect

Time: ✅ 1.371µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ split_noaspect

Time: ✅ 0.579µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.5%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.9%

✅ splitlines_aspect

Time: ✅ 1.384µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ splitlines_noaspect

Time: ✅ 0.584µs (SLO: <10.000µs 📉 -94.2%) vs baseline: ~same

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6%

✅ iastpropagation - 8/8

✅ no-propagation

Time: ✅ 49.494µs (SLO: <60.000µs 📉 -17.5%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ propagation_enabled

Time: ✅ 171.174µs (SLO: <190.000µs -9.9%) vs baseline: -0.6%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ propagation_enabled_100

Time: ✅ 1.891ms (SLO: <2.300ms 📉 -17.8%) vs baseline: +0.2%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ propagation_enabled_1000

Time: ✅ 32.198ms (SLO: <34.550ms -6.8%) vs baseline: -0.4%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.759ms (SLO: <42.000ms -3.0%) vs baseline: +0.7%

Memory: ✅ 34.583MB (SLO: <39.000MB 📉 -11.3%) vs baseline: +5.0%

✅ add-link

Time: ✅ 36.521ms (SLO: <38.550ms -5.3%) vs baseline: +0.5%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +5.0%

✅ add-metrics

Time: ✅ 219.762ms (SLO: <232.000ms -5.3%) vs baseline: -0.8%

Memory: ✅ 34.465MB (SLO: <39.000MB 📉 -11.6%) vs baseline: +4.9%

✅ add-tags

Time: ✅ 213.454ms (SLO: <221.600ms -3.7%) vs baseline: +1.3%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +5.0%

✅ get-context

Time: ✅ 29.176ms (SLO: <31.300ms -6.8%) vs baseline: +0.9%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +5.0%

✅ is-recording

Time: ✅ 29.134ms (SLO: <31.000ms -6.0%) vs baseline: +0.3%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.7%

✅ record-exception

Time: ✅ 63.333ms (SLO: <65.850ms -3.8%) vs baseline: -0.8%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.4%

✅ set-status

Time: ✅ 31.995ms (SLO: <34.150ms -6.3%) vs baseline: +0.6%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.9%

✅ start

Time: ✅ 28.881ms (SLO: <30.150ms -4.2%) vs baseline: +0.4%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +5.0%

✅ start-finish

Time: ✅ 34.059ms (SLO: <35.350ms -3.7%) vs baseline: +0.9%

Memory: ✅ 34.505MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.8%

✅ start-finish-telemetry

Time: ✅ 33.937ms (SLO: <35.450ms -4.3%) vs baseline: -1.0%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.9%

✅ update-name

Time: ✅ 31.155ms (SLO: <33.400ms -6.7%) vs baseline: +0.3%

Memory: ✅ 34.426MB (SLO: <39.000MB 📉 -11.7%) vs baseline: +4.6%

✅ packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 341.441ms (SLO: <354.300ms -3.6%) vs baseline: -0.3%

Memory: ✅ 37.935MB (SLO: <40.000MB -5.2%) vs baseline: +4.9%

✅ cache_on

Time: ✅ 0.389µs (SLO: <10.000µs 📉 -96.1%) vs baseline: ~same

Memory: ✅ 37.554MB (SLO: <39.000MB -3.7%) vs baseline: +5.8%

✅ packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 154.580µs (SLO: <170.000µs -9.1%) vs baseline: ~same

Memory: ✅ 37.368MB (SLO: <38.500MB -2.9%) vs baseline: +4.9%

✅ import_many_cached

Time: ✅ 120.248µs (SLO: <130.000µs -7.5%) vs baseline: -0.4%

Memory: ✅ 37.383MB (SLO: <38.500MB -2.9%) vs baseline: +4.6%

✅ import_many_stdlib

Time: ✅ 1.612ms (SLO: <1.750ms -7.9%) vs baseline: ~same

Memory: ✅ 37.500MB (SLO: <38.500MB -2.6%) vs baseline: +4.6%

✅ import_many_stdlib_cached

Time: ✅ 0.976ms (SLO: <1.100ms 📉 -11.3%) vs baseline: +0.9%

Memory: ✅ 37.432MB (SLO: <38.500MB -2.8%) vs baseline: +4.7%

✅ import_many_unknown

Time: ✅ 826.749µs (SLO: <890.000µs -7.1%) vs baseline: -1.2%

Memory: ✅ 37.425MB (SLO: <38.500MB -2.8%) vs baseline: +4.7%

✅ import_many_unknown_cached

Time: ✅ 791.027µs (SLO: <870.000µs -9.1%) vs baseline: -0.3%

Memory: ✅ 37.506MB (SLO: <38.500MB -2.6%) vs baseline: +4.8%

✅ import_one

Time: ✅ 19.762µs (SLO: <30.000µs 📉 -34.1%) vs baseline: -1.2%

Memory: ✅ 37.371MB (SLO: <39.000MB -4.2%) vs baseline: +5.0%

✅ import_one_cache

Time: ✅ 6.290µs (SLO: <10.000µs 📉 -37.1%) vs baseline: -0.4%

Memory: ✅ 37.259MB (SLO: <38.500MB -3.2%) vs baseline: +4.6%

✅ import_one_stdlib

Time: ✅ 18.668µs (SLO: <20.000µs -6.7%) vs baseline: -0.4%

Memory: ✅ 37.251MB (SLO: <38.500MB -3.2%) vs baseline: +4.6%

✅ import_one_stdlib_cache

Time: ✅ 6.293µs (SLO: <10.000µs 📉 -37.1%) vs baseline: +0.4%

Memory: ✅ 37.410MB (SLO: <38.500MB -2.8%) vs baseline: +5.2%

✅ import_one_unknown

Time: ✅ 45.478µs (SLO: <50.000µs -9.0%) vs baseline: -0.3%

Memory: ✅ 37.387MB (SLO: <38.500MB -2.9%) vs baseline: +4.8%

✅ import_one_unknown_cache

Time: ✅ 6.444µs (SLO: <10.000µs 📉 -35.6%) vs baseline: +2.7%

Memory: ✅ 37.395MB (SLO: <38.500MB -2.9%) vs baseline: +5.2%

✅ ratelimiter - 12/12

✅ defaults

Time: ✅ 2.350µs (SLO: <10.000µs 📉 -76.5%) vs baseline: +0.2%

Memory: ✅ 31.752MB (SLO: <34.000MB -6.6%) vs baseline: +4.9%

✅ high_rate_limit

Time: ✅ 2.416µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +0.4%

Memory: ✅ 31.733MB (SLO: <34.000MB -6.7%) vs baseline: +4.8%

✅ long_window

Time: ✅ 2.370µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +0.7%

Memory: ✅ 31.792MB (SLO: <34.000MB -6.5%) vs baseline: +4.7%

✅ low_rate_limit

Time: ✅ 2.375µs (SLO: <10.000µs 📉 -76.2%) vs baseline: +0.3%

Memory: ✅ 31.811MB (SLO: <34.000MB -6.4%) vs baseline: +5.1%

✅ no_rate_limit

Time: ✅ 0.829µs (SLO: <10.000µs 📉 -91.7%) vs baseline: -0.4%

Memory: ✅ 31.752MB (SLO: <34.000MB -6.6%) vs baseline: +4.8%

✅ short_window

Time: ✅ 2.510µs (SLO: <10.000µs 📉 -74.9%) vs baseline: +0.4%

Memory: ✅ 31.772MB (SLO: <34.000MB -6.6%) vs baseline: +4.9%

✅ recursivecomputation - 8/8

✅ deep

Time: ✅ 310.045ms (SLO: <320.950ms -3.4%) vs baseline: +0.1%

Memory: ✅ 32.853MB (SLO: <34.500MB -4.8%) vs baseline: +4.9%

✅ deep-profiled

Time: ✅ 326.482ms (SLO: <359.150ms -9.1%) vs baseline: -0.1%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%

✅ medium

Time: ✅ 7.069ms (SLO: <7.400ms -4.5%) vs baseline: +0.3%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9%

✅ shallow

Time: ✅ 0.950ms (SLO: <1.050ms -9.5%) vs baseline: ~same

Memory: ✅ 32.027MB (SLO: <34.000MB -5.8%) vs baseline: +4.7%

✅ samplingrules - 8/8

✅ average_match

Time: ✅ 146.962µs (SLO: <290.000µs 📉 -49.3%) vs baseline: -1.0%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7%

✅ high_match

Time: ✅ 194.591µs (SLO: <480.000µs 📉 -59.5%) vs baseline: ~same

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ low_match

Time: ✅ 100.091µs (SLO: <120.000µs 📉 -16.6%) vs baseline: ~same

Memory: ✅ 632.642MB (SLO: <700.000MB -9.6%) vs baseline: +4.9%

✅ very_low_match

Time: ✅ 2.886ms (SLO: <8.500ms 📉 -66.0%) vs baseline: -0.6%

Memory: ✅ 70.289MB (SLO: <75.000MB -6.3%) vs baseline: +5.0%

✅ sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.478µs (SLO: <20.000µs 📉 -47.6%) vs baseline: ~same

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +4.9%

✅ all-enabled

Time: ✅ 40.094µs (SLO: <50.000µs 📉 -19.8%) vs baseline: +0.4%

Memory: ✅ 32.519MB (SLO: <34.000MB -4.4%) vs baseline: +4.6%

✅ collectipvariant_exists

Time: ✅ 40.610µs (SLO: <50.000µs 📉 -18.8%) vs baseline: ~same

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.9%

✅ no-collectipvariant

Time: ✅ 39.961µs (SLO: <50.000µs 📉 -20.1%) vs baseline: ~same

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.8%

✅ no-useragentvariant

Time: ✅ 38.822µs (SLO: <50.000µs 📉 -22.4%) vs baseline: +0.1%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +4.9%

✅ obfuscation-no-query

Time: ✅ 40.742µs (SLO: <50.000µs 📉 -18.5%) vs baseline: +1.1%

Memory: ✅ 32.637MB (SLO: <34.000MB -4.0%) vs baseline: +4.9%

✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.841µs (SLO: <90.000µs 📉 -15.7%) vs baseline: +0.4%

Memory: ✅ 32.991MB (SLO: <34.000MB -3.0%) vs baseline: +4.9%

✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.556µs (SLO: <90.000µs 📉 -14.9%) vs baseline: +0.7%

Memory: ✅ 32.971MB (SLO: <34.000MB -3.0%) vs baseline: +4.8%

✅ obfuscation-send-querystring-disabled

Time: ✅ 154.906µs (SLO: <170.000µs -8.9%) vs baseline: +0.7%

Memory: ✅ 32.991MB (SLO: <34.500MB -4.4%) vs baseline: +4.9%

✅ obfuscation-worst-case-explicit-query

Time: ✅ 149.361µs (SLO: <160.000µs -6.6%) vs baseline: +1.3%

Memory: ✅ 32.912MB (SLO: <34.500MB -4.6%) vs baseline: +4.6%

✅ obfuscation-worst-case-implicit-query

Time: ✅ 155.551µs (SLO: <170.000µs -8.5%) vs baseline: +0.9%

Memory: ✅ 32.932MB (SLO: <34.500MB -4.5%) vs baseline: +4.7%

✅ useragentvariant_exists_1

Time: ✅ 39.383µs (SLO: <50.000µs 📉 -21.2%) vs baseline: +0.1%

Memory: ✅ 32.519MB (SLO: <34.000MB -4.4%) vs baseline: +4.8%

✅ useragentvariant_exists_2

Time: ✅ 40.683µs (SLO: <50.000µs 📉 -18.6%) vs baseline: +0.9%

Memory: ✅ 32.637MB (SLO: <34.000MB -4.0%) vs baseline: +5.0%

✅ useragentvariant_exists_3

Time: ✅ 39.878µs (SLO: <50.000µs 📉 -20.2%) vs baseline: -0.3%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +4.8%

✅ useragentvariant_not_exists_1

Time: ✅ 39.426µs (SLO: <50.000µs 📉 -21.1%) vs baseline: -0.1%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +4.8%

✅ useragentvariant_not_exists_2

Time: ✅ 39.315µs (SLO: <50.000µs 📉 -21.4%) vs baseline: +0.4%

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.9%

✅ span - 26/26

✅ add-event

Time: ✅ 24.225ms (SLO: <26.200ms -7.5%) vs baseline: ~same

Memory: ✅ 51.624MB (SLO: <53.000MB -2.6%) vs baseline: +4.5%

✅ add-metrics

Time: ✅ 93.290ms (SLO: <98.350ms -5.1%) vs baseline: -0.8%

Memory: ✅ 606.056MB (SLO: <961.000MB 📉 -36.9%) vs baseline: +4.9%

✅ add-tags

Time: ✅ 150.964ms (SLO: <168.550ms 📉 -10.4%) vs baseline: -0.1%

Memory: ✅ 607.003MB (SLO: <962.500MB 📉 -36.9%) vs baseline: +4.9%

✅ get-context

Time: ✅ 22.437ms (SLO: <23.700ms -5.3%) vs baseline: +0.4%

Memory: ✅ 50.405MB (SLO: <53.000MB -4.9%) vs baseline: +4.7%

✅ is-recording

Time: ✅ 22.761ms (SLO: <23.900ms -4.8%) vs baseline: +0.6%

Memory: ✅ 50.358MB (SLO: <53.000MB -5.0%) vs baseline: +4.6%

✅ record-exception

Time: ✅ 42.346ms (SLO: <44.500ms -4.8%) vs baseline: +0.2%

Memory: ✅ 43.521MB (SLO: <53.000MB 📉 -17.9%) vs baseline: +5.0%

✅ set-status

Time: ✅ 24.448ms (SLO: <26.000ms -6.0%) vs baseline: +0.4%

Memory: ✅ 50.356MB (SLO: <53.000MB -5.0%) vs baseline: +4.6%

✅ start

Time: ✅ 22.407ms (SLO: <23.500ms -4.7%) vs baseline: +1.3%

Memory: ✅ 50.441MB (SLO: <53.000MB -4.8%) vs baseline: +4.7%

✅ start-finish

Time: ✅ 52.137ms (SLO: <55.500ms -6.1%) vs baseline: +0.7%

Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +4.7%

✅ start-finish-telemetry

Time: ✅ 52.954ms (SLO: <58.300ms -9.2%) vs baseline: -0.4%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.9%

✅ start-finish-traceid128

Time: ✅ 55.090ms (SLO: <60.050ms -8.3%) vs baseline: -0.1%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1%

✅ start-traceid128

Time: ✅ 22.581ms (SLO: <24.600ms -8.2%) vs baseline: -0.2%

Memory: ✅ 50.478MB (SLO: <53.000MB -4.8%) vs baseline: +4.9%

✅ update-name

Time: ✅ 23.383ms (SLO: <24.100ms -3.0%) vs baseline: +0.7%

Memory: ✅ 51.057MB (SLO: <53.000MB -3.7%) vs baseline: +4.8%

✅ telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 3.082µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -0.9%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.8%

✅ 1-count-metrics-100-times

Time: ✅ 211.546µs (SLO: <250.000µs 📉 -15.4%) vs baseline: -0.7%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0%

✅ 1-distribution-metric-1-times

Time: ✅ 2.907µs (SLO: <20.000µs 📉 -85.5%) vs baseline: +0.2%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.2%

✅ 1-distribution-metrics-100-times

Time: ✅ 191.915µs (SLO: <220.000µs 📉 -12.8%) vs baseline: +0.6%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.6%

✅ 1-gauge-metric-1-times

Time: ✅ 2.065µs (SLO: <20.000µs 📉 -89.7%) vs baseline: +0.9%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8%

✅ 1-gauge-metrics-100-times

Time: ✅ 125.416µs (SLO: <150.000µs 📉 -16.4%) vs baseline: +0.5%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.8%

✅ 1-rate-metric-1-times

Time: ✅ 3.066µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -1.1%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1%

✅ 1-rate-metrics-100-times

Time: ✅ 211.885µs (SLO: <250.000µs 📉 -15.2%) vs baseline: -0.9%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.9%

✅ 100-count-metrics-100-times

Time: ✅ 21.218ms (SLO: <23.500ms -9.7%) vs baseline: -0.4%

Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.2%

✅ 100-distribution-metrics-100-times

Time: ✅ 1.981ms (SLO: <2.250ms 📉 -12.0%) vs baseline: +1.2%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.8%

✅ 100-gauge-metrics-100-times

Time: ✅ 1.286ms (SLO: <1.550ms 📉 -17.0%) vs baseline: +0.6%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ 100-rate-metrics-100-times

Time: ✅ 2.174ms (SLO: <2.550ms 📉 -14.8%) vs baseline: +0.2%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1%

✅ flush-1-metric

Time: ✅ 4.150µs (SLO: <20.000µs 📉 -79.3%) vs baseline: +0.4%

Memory: ✅ 32.027MB (SLO: <34.000MB -5.8%) vs baseline: +4.6%

✅ flush-100-metrics

Time: ✅ 181.703µs (SLO: <250.000µs 📉 -27.3%) vs baseline: +0.2%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7%

✅ flush-1000-metrics

Time: ✅ 2.222ms (SLO: <2.500ms 📉 -11.1%) vs baseline: +0.6%

Memory: ✅ 32.932MB (SLO: <34.500MB -4.5%) vs baseline: +5.0%

✅ tracer - 6/6

✅ large

Time: ✅ 30.575ms (SLO: <32.950ms -7.2%) vs baseline: +1.1%

Memory: ✅ 33.227MB (SLO: <34.500MB -3.7%) vs baseline: +4.9%

✅ medium

Time: ✅ 2.974ms (SLO: <3.200ms -7.1%) vs baseline: +1.1%

Memory: ✅ 31.654MB (SLO: <34.000MB -6.9%) vs baseline: +4.9%

✅ small

Time: ✅ 335.520µs (SLO: <370.000µs -9.3%) vs baseline: -0.3%

Memory: ✅ 31.733MB (SLO: <34.000MB -6.7%) vs baseline: +5.1%

ℹ️ Scenarios Missing SLO Configuration (9 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

coreapiscenario-core_dispatch_listeners
coreapiscenario-core_dispatch_no_listeners
coreapiscenario-core_dispatch_with_results_listeners
coreapiscenario-core_dispatch_with_results_no_listeners
djangosimple-baseline
errortrackingdjangosimple-baseline
errortrackingflasksqli-baseline
flasksimple-baseline
flasksqli-baseline

ddtrace/_trace/trace_handlers.py

ddtrace/internal/sampling.py

ddtrace/_trace/trace_handlers.py

ddtrace/contrib/internal/asgi/middleware.py

ddtrace/_trace/trace_handlers.py

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>

ddtrace/_trace/trace_handlers.py

mabdinur

Left two nits. Overall LGTM

ddtrace/_trace/trace_handlers.py

ddtrace/contrib/internal/asgi/middleware.py

wip - add disconnect handler

e3c3f69

wip

be37fb9

quinna-h added 7 commits August 19, 2025 16:31

wip

e28edf4

Merge branch 'main' into refactor-asgi-core-api

51ff1a9

wip

5fb38e6

wip

6bbad5c

wip

bb292df

unstage irrelevant changes

4e9f582

wip

b738746

quinna-h commented Aug 21, 2025

View reviewed changes

ddtrace/_trace/trace_handlers.py Show resolved Hide resolved

quinna-h commented Aug 21, 2025

View reviewed changes

ddtrace/_trace/trace_handlers.py Outdated Show resolved Hide resolved

quinna-h commented Aug 21, 2025

View reviewed changes

ddtrace/_trace/trace_handlers.py Outdated Show resolved Hide resolved

quinna-h commented Aug 21, 2025

View reviewed changes

ddtrace/internal/sampling.py Outdated Show resolved Hide resolved

quinna-h commented Aug 21, 2025

View reviewed changes

ddtrace/_trace/trace_handlers.py Show resolved Hide resolved

update sampling

eac149a

quinna-h requested review from brettlangdon, emmettbutler and mabdinur August 22, 2025 14:24

brettlangdon reviewed Aug 22, 2025

View reviewed changes

github-actions bot added the stale label Sep 22, 2025

quinna-h changed the title ~~chore(asgi) - refactor to use core API~~ chore(asgi) - refactor websocket code to use core API Sep 22, 2025

quinna-h added 3 commits September 22, 2025 16:09

Merge branch 'main' into refactor-asgi-core-api

e83fcc9

Merge branch 'main' into refactor-asgi-core-api

e0197e1

wip - fix rebase

f4b9030

github-actions bot removed the stale label Sep 23, 2025

quinna-h and others added 2 commits September 23, 2025 13:41

update trace handler + middleware + snapshot files

861d58b

Update ddtrace/contrib/internal/asgi/middleware.py

d777bcd

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>

quinna-h added 3 commits September 24, 2025 12:21

Merge branch 'main' into refactor-asgi-core-api

4a506af

style lint

3d29070

linting

f37c0f1

quinna-h commented Sep 26, 2025

View reviewed changes

ddtrace/_trace/trace_handlers.py Outdated Show resolved Hide resolved

quinna-h marked this pull request as ready for review September 26, 2025 18:49

quinna-h requested review from a team as code owners September 26, 2025 18:49

quinna-h requested a review from wantsui September 26, 2025 18:49

quinna-h changed the title ~~chore(asgi) - refactor websocket code to use core API~~ chore(asgi): refactor websocket code to use core API Sep 26, 2025

quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 26, 2025

quinna-h added 2 commits September 30, 2025 11:18

cleanup code

e105b8c

formatting

2c5101b

quinna-h requested a review from brettlangdon September 30, 2025 15:31

Merge branch 'main' into refactor-asgi-core-api

eec1bbc

mabdinur reviewed Oct 1, 2025

View reviewed changes

ddtrace/_trace/trace_handlers.py Outdated Show resolved Hide resolved

ddtrace/_trace/trace_handlers.py Show resolved Hide resolved

quinna-h added 2 commits October 1, 2025 11:09

Merge branch 'main' into refactor-asgi-core-api

cfcf3cc

wip

ce2ccb4

mabdinur approved these changes Oct 3, 2025

View reviewed changes

emmettbutler approved these changes Oct 3, 2025

View reviewed changes

ddtrace/contrib/internal/asgi/middleware.py Show resolved Hide resolved

quinna-h merged commit ca78f69 into main Oct 3, 2025
906 checks passed

quinna-h deleted the refactor-asgi-core-api branch October 3, 2025 20:30

chore(asgi): refactor websocket code to use core API #14345

chore(asgi): refactor websocket code to use core API #14345

Uh oh!

Conversation

quinna-h commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Reviewer Checklist

Uh oh!

github-actions bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bootstrap import analysis

Summary

Import time breakdown

Uh oh!

pr-commenter bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance SLOs

✅ add_aspect

✅ add_inplace_aspect

✅ add_inplace_noaspect

✅ add_noaspect

✅ bytearray_aspect

✅ bytearray_extend_aspect

✅ bytearray_extend_noaspect

✅ bytearray_noaspect

✅ bytes_aspect

✅ bytes_noaspect

✅ bytesio_aspect

✅ bytesio_noaspect

✅ capitalize_aspect

✅ capitalize_noaspect

✅ casefold_aspect

✅ casefold_noaspect

✅ decode_aspect

✅ decode_noaspect

✅ encode_aspect

✅ encode_noaspect

✅ format_aspect

✅ format_map_aspect

✅ format_map_noaspect

✅ format_noaspect

✅ index_aspect

✅ index_noaspect

✅ join_aspect

✅ join_noaspect

✅ ljust_aspect

✅ ljust_noaspect

✅ lower_aspect

✅ lower_noaspect

✅ lstrip_aspect

✅ lstrip_noaspect

✅ modulo_aspect

✅ modulo_aspect_for_bytearray_bytearray

✅ modulo_aspect_for_bytes

✅ modulo_aspect_for_bytes_bytearray

✅ modulo_noaspect

✅ replace_aspect

✅ replace_noaspect

✅ repr_aspect

✅ repr_noaspect

✅ rstrip_aspect

✅ rstrip_noaspect

✅ slice_aspect

✅ slice_noaspect

✅ stringio_aspect

✅ stringio_noaspect

✅ strip_aspect

✅ strip_noaspect

✅ swapcase_aspect

✅ swapcase_noaspect

✅ title_aspect

✅ title_noaspect

✅ translate_aspect

✅ translate_noaspect

✅ upper_aspect

✅ upper_noaspect

quinna-h commented Aug 18, 2025 •

edited

Loading

github-actions bot commented Aug 18, 2025 •

edited

Loading

github-actions bot commented Aug 18, 2025 •

edited

Loading

pr-commenter bot commented Aug 18, 2025 •

edited

Loading