-
Notifications
You must be signed in to change notification settings - Fork 470
fix(profiling): re-accept interval for memory profile collector [backport 3.12] #14485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taegyunkim
approved these changes
Sep 3, 2025
Contributor
|
|
…ckport 3.12] In #14205 we removed the `_interval` parameter for the `MemoryCollector`. This was a mistake. Now the memory profile collector thread basically spins in a tight loop because the interval is 0. Add that parameter back. Backports #14276 to the 3.12 branch. This was fixed in 3.12.0 but somehow didn't make it to 3.12.1 or 3.12.2
bb070ce to
bb57fef
Compare
taegyunkim
approved these changes
Sep 3, 2025
brettlangdon
approved these changes
Sep 3, 2025
Contributor
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 280 ± 6 ms. The average import time from base is: 281 ± 6 ms. The import time difference between this PR and base is: -0.4 ± 0.3 ms. The difference is not statistically significant (z = -1.27). Import time breakdownThe following import paths have shrunk:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #14205 we removed the
_intervalparameter for theMemoryCollector.This was a mistake. Now the memory profile collector thread basically
spins in a tight loop because the interval is 0. Add that parameter
back.
Backports #14276 to the 3.12 branch. This was fixed in 3.12.0 but
somehow didn't make it to 3.12.1 or 3.12.2
The actual fix was picked up by #14487 and this PR is mainly to add a release note.
Checklist
Reviewer Checklist