-
Notifications
You must be signed in to change notification settings - Fork 467
feat(llmobs): allow project override when creating experiment #14923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 253 ± 6 ms. The average import time from base is: 255 ± 6 ms. The import time difference between this PR and base is: -2.5 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate gary/mlob-4211 (59bec46) with baseline main (28fecf2) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.002µs (SLO: <10.000µs 📉 -50.0%) vs baseline: 📈 +14.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.090µs (SLO: <10.000µs 📉 -89.1%) vs baseline: ~same Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.747µs (SLO: <10.000µs 📉 -32.5%) vs baseline: 📈 +10.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 2.302µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.809µs (SLO: <10.000µs 📉 -61.9%) vs baseline: +9.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.571µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.883µs (SLO: <10.000µs 📉 -51.2%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.603µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.994µs (SLO: <10.000µs 📉 -60.1%) vs baseline: +9.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.707µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 5.271µs (SLO: <10.000µs 📉 -47.3%) vs baseline: 📈 +15.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.399µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +0.1% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.453ms (SLO: <22.300ms -8.3%) vs baseline: -0.4% Memory: ✅ 65.509MB (SLO: <67.000MB -2.2%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.343ms (SLO: <1.450ms -7.4%) vs baseline: -0.2% Memory: ✅ 64.559MB (SLO: <67.000MB -3.6%) vs baseline: +4.8% ✅ iastTime: ✅ 20.447ms (SLO: <22.250ms -8.1%) vs baseline: -0.2% Memory: ✅ 65.485MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.288ms (SLO: <16.550ms -7.6%) vs baseline: ~same Memory: ✅ 53.705MB (SLO: <54.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 20.535ms (SLO: <21.750ms -5.6%) vs baseline: +0.2% Memory: ✅ 65.494MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.226ms (SLO: <28.200ms -7.0%) vs baseline: +0.4% Memory: ✅ 67.557MB (SLO: <69.500MB -2.8%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.462ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 65.525MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.068ms (SLO: <23.500ms -6.1%) vs baseline: +0.2% Memory: ✅ 66.492MB (SLO: <67.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.322ms (SLO: <21.500ms 📉 -10.1%) vs baseline: +0.3% Memory: ✅ 65.416MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.552ms (SLO: <17.500ms -5.4%) vs baseline: -0.3% Memory: ✅ 65.423MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.425ms (SLO: <21.750ms -6.1%) vs baseline: -0.1% Memory: ✅ 71.517MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +5.1% ✅ tracer-no-cachesTime: ✅ 18.403ms (SLO: <19.650ms -6.3%) vs baseline: ~same Memory: ✅ 65.462MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.783ms (SLO: <20.100ms -6.6%) vs baseline: +0.4% Memory: ✅ 65.076MB (SLO: <67.000MB -2.9%) vs baseline: +4.4% ✅ tracer-no-middlewareTime: ✅ 20.189ms (SLO: <21.500ms -6.1%) vs baseline: ~same Memory: ✅ 65.463MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.344ms (SLO: <22.000ms -7.5%) vs baseline: +0.6% Memory: ✅ 65.471MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.039ms (SLO: <19.850ms -9.1%) vs baseline: -0.3% Memory: ✅ 65.333MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.084ms (SLO: <19.400ms -6.8%) vs baseline: +0.3% Memory: ✅ 65.235MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.110ms (SLO: <19.450ms -6.9%) vs baseline: +0.3% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.596ms (SLO: <4.750ms -3.2%) vs baseline: +1.1% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.605ms (SLO: <6.750ms -2.1%) vs baseline: +0.3% Memory: ✅ 62.010MB (SLO: <65.000MB -4.6%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.585ms (SLO: <4.750ms -3.5%) vs baseline: +0.5% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 45.480MB (SLO: <47.000MB -3.2%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.863ms (SLO: <2.000ms -6.9%) vs baseline: +0.1% Memory: ✅ 42.349MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -8.9%) vs baseline: +0.1% Memory: ✅ 46.627MB (SLO: <47.000MB 🟡 -0.8%) vs baseline: +5.2% ✅ resource-renamingTime: ✅ 3.378ms (SLO: <3.650ms -7.5%) vs baseline: ~same Memory: ✅ 52.436MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +5.3% ✅ tracerTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: ~same Memory: ✅ 52.267MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: -0.1% Memory: ✅ 58.393MB (SLO: <60.000MB -2.7%) vs baseline: +5.1% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 40.971ms (SLO: <47.150ms 📉 -13.1%) vs baseline: +0.3% Memory: ✅ 44.229MB (SLO: <47.000MB -5.9%) vs baseline: +5.2% ✅ add-metricsTime: ✅ 316.188ms (SLO: <344.800ms -8.3%) vs baseline: ~same Memory: ✅ 617.079MB (SLO: <630.000MB -2.1%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 289.065ms (SLO: <314.000ms -7.9%) vs baseline: -0.4% Memory: ✅ 618.754MB (SLO: <630.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ get-contextTime: ✅ 80.875ms (SLO: <92.350ms 📉 -12.4%) vs baseline: ~same Memory: ✅ 39.702MB (SLO: <46.500MB 📉 -14.6%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 38.262ms (SLO: <44.500ms 📉 -14.0%) vs baseline: ~same Memory: ✅ 43.624MB (SLO: <47.500MB -8.2%) vs baseline: +5.2% ✅ record-exceptionTime: ✅ 58.283ms (SLO: <67.650ms 📉 -13.8%) vs baseline: -0.5% Memory: ✅ 40.106MB (SLO: <47.000MB 📉 -14.7%) vs baseline: +4.9% ✅ set-statusTime: ✅ 44.269ms (SLO: <50.400ms 📉 -12.2%) vs baseline: +0.5% Memory: ✅ 43.589MB (SLO: <47.000MB -7.3%) vs baseline: +4.9% ✅ startTime: ✅ 37.583ms (SLO: <43.450ms 📉 -13.5%) vs baseline: ~same Memory: ✅ 43.573MB (SLO: <47.000MB -7.3%) vs baseline: +4.9% ✅ start-finishTime: ✅ 82.864ms (SLO: <88.000ms -5.8%) vs baseline: +0.4% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 84.118ms (SLO: <89.000ms -5.5%) vs baseline: ~same Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.7% ✅ update-nameTime: ✅ 39.168ms (SLO: <45.150ms 📉 -13.2%) vs baseline: +0.4% Memory: ✅ 43.937MB (SLO: <47.000MB -6.5%) vs baseline: +5.0% 🟡 span - 26/26✅ add-eventTime: ✅ 20.626ms (SLO: <22.500ms -8.3%) vs baseline: +0.2% Memory: ✅ 49.607MB (SLO: <53.000MB -6.4%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 90.732ms (SLO: <93.500ms -3.0%) vs baseline: +1.0% Memory: ✅ 690.399MB (SLO: <961.000MB 📉 -28.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 149.029ms (SLO: <155.000ms -3.9%) vs baseline: +0.9% Memory: ✅ 690.320MB (SLO: <962.500MB 📉 -28.3%) vs baseline: +4.7% ✅ get-contextTime: ✅ 18.969ms (SLO: <20.500ms -7.5%) vs baseline: +0.3% Memory: ✅ 48.486MB (SLO: <53.000MB -8.5%) vs baseline: +5.2% ✅ is-recordingTime: ✅ 19.047ms (SLO: <20.500ms -7.1%) vs baseline: -0.9% Memory: ✅ 48.428MB (SLO: <53.000MB -8.6%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 37.649ms (SLO: <40.000ms -5.9%) vs baseline: +0.2% Memory: ✅ 42.490MB (SLO: <53.000MB 📉 -19.8%) vs baseline: +4.9% ✅ set-statusTime: ✅ 20.918ms (SLO: <22.000ms -4.9%) vs baseline: +0.7% Memory: ✅ 48.421MB (SLO: <53.000MB -8.6%) vs baseline: +4.8% ✅ startTime: ✅ 18.955ms (SLO: <20.500ms -7.5%) vs baseline: +1.6% Memory: ✅ 48.477MB (SLO: <53.000MB -8.5%) vs baseline: +5.0% ✅ start-finishTime: ✅ 51.582ms (SLO: <52.500ms 🟡 -1.7%) vs baseline: +0.6% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 52.862ms (SLO: <54.500ms -3.0%) vs baseline: ~same Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ start-finish-traceid128Time: ✅ 54.945ms (SLO: <56.000ms 🟡 -1.9%) vs baseline: +0.3% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.1% ✅ start-traceid128Time: ✅ 19.334ms (SLO: <22.500ms 📉 -14.1%) vs baseline: +1.3% Memory: ✅ 48.423MB (SLO: <53.000MB -8.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 19.243ms (SLO: <22.000ms 📉 -12.5%) vs baseline: -0.6% Memory: ✅ 49.132MB (SLO: <53.000MB -7.3%) vs baseline: +4.9%
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release note lgtm
releasenotes/notes/llmobs-dne-add-project-name-arg-to-create-experiment-a1f4fb61aea22983.yaml
Outdated
Show resolved
Hide resolved
…xperiment-a1f4fb61aea22983.yaml Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Description
this allows an experiment to be saved to a different project from the one defined in
LLMObs.enableTesting
with the following script that overrides the project name in
LLMObs.experiment:we see the experiment in the project "new-gh-project":

and it appears normal
https://dddev.datadoghq.com/llm/experiments/02a69ecb-7de5-4569-9b5a-8524e096d0d5?spanId=1743163979865576740
and nothing else in "Onboarding" (from the enable call)

Risks
None