-
Notifications
You must be signed in to change notification settings - Fork 468
chore(writer): enable native writer by default #14952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(writer): enable native writer by default #14952
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 3 ms. The average import time from base is: 245 ± 3 ms. The import time difference between this PR and base is: 6.0 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate vianney/enable-native-writer-by-default (05992df) with baseline main (c529066) 📈 Performance Regressions (18 suites)📈 coreapiscenario - 10/10 (1 unstable)
|
63f9d8c to
fa1234a
Compare
d7aca9e to
4d2cb27
Compare
Enabling the native writer increase the memory usage due to the inefficient double serialization used to pass traces.
4d2cb27 to
1642b8a
Compare
9e053f6 to
c3f45a8
Compare
Yun-Kim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion for ignoring telemetry requests in mcp tests
This reverts commit 9c7121e.
Description
Enables the native writer by default. The native writer can still be disabled through
_DD_TRACE_WRITER_NATIVE.Testing
All tests are run with the native writer. The native writer have also been enabled on some services internally for dogfooding purposes.
Risks
This changes the logic behind trace export and client-side stats computation (for customers who enabled it). We expect no change in behavior for trace exporting. Client-side stats behavior may show some differences as the current python implementation is not fully compliant with the client-side stats spec.
Additional Notes