-
Notifications
You must be signed in to change notification settings - Fork 468
feat(ffe): integrate datadog-ffe #15098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
cef19ac to
b4dfcf7
Compare
b4dfcf7 to
762fd7f
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 8 ms. The average import time from base is: 243 ± 4 ms. The import time difference between this PR and base is: 8.3 ± 0.3 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate datadog-ffe (ee2ecfc) with baseline main (d86c66f) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30✅ 1-count-metric-1-timesTime: ✅ 3.065µs (SLO: <20.000µs 📉 -84.7%) vs baseline: +4.8% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.5% ✅ 1-count-metrics-100-timesTime: ✅ 207.547µs (SLO: <220.000µs -5.7%) vs baseline: +4.3% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.384µs (SLO: <20.000µs 📉 -83.1%) vs baseline: +3.7% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.6% ❌ 1-distribution-metrics-100-timesTime: ❌ 221.921µs (SLO: <220.000µs +0.9%) vs baseline: +5.0% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.192µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +0.3% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.4% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.501µs (SLO: <150.000µs -9.0%) vs baseline: ~same Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.148µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +2.4% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.7% ✅ 1-rate-metrics-100-timesTime: ✅ 221.209µs (SLO: <250.000µs 📉 -11.5%) vs baseline: +4.8% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.4% ✅ 100-count-metrics-100-timesTime: ✅ 20.833ms (SLO: <22.000ms -5.3%) vs baseline: +4.5% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.294ms (SLO: <2.300ms 🟡 -0.3%) vs baseline: +3.4% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.3% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.414ms (SLO: <1.550ms -8.8%) vs baseline: +1.4% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +5.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.267ms (SLO: <2.550ms 📉 -11.1%) vs baseline: +3.9% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.8% ✅ flush-1-metricTime: ✅ 4.606µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +5.0% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +6.0% ✅ flush-100-metricsTime: ✅ 177.997µs (SLO: <250.000µs 📉 -28.8%) vs baseline: +1.1% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.6% ✅ flush-1000-metricsTime: ✅ 2.139ms (SLO: <2.500ms 📉 -14.4%) vs baseline: +0.8% Memory: ✅ 32.952MB (SLO: <34.500MB -4.5%) vs baseline: +5.6% 📈 Performance Regressions (3 suites)📈 iast_aspects - 40/40✅ re_expand_aspectTime: ✅ 33.698µs (SLO: <40.000µs 📉 -15.8%) vs baseline: +6.0% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.3% ✅ re_expand_noaspectTime: ✅ 29.936µs (SLO: <40.000µs 📉 -25.2%) vs baseline: +4.5% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.5% ✅ re_findall_aspectTime: ✅ 2.966µs (SLO: <10.000µs 📉 -70.3%) vs baseline: +2.1% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ re_findall_noaspectTime: ✅ 1.422µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +0.6% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.5% ✅ re_finditer_aspectTime: ✅ 4.607µs (SLO: <10.000µs 📉 -53.9%) vs baseline: +5.3% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.6% ✅ re_finditer_noaspectTime: ✅ 1.410µs (SLO: <10.000µs 📉 -85.9%) vs baseline: ~same Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.3% ✅ re_fullmatch_aspectTime: ✅ 2.889µs (SLO: <10.000µs 📉 -71.1%) vs baseline: +6.8% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.5% ✅ re_fullmatch_noaspectTime: ✅ 1.291µs (SLO: <10.000µs 📉 -87.1%) vs baseline: -1.0% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ re_group_aspectTime: ✅ 3.221µs (SLO: <10.000µs 📉 -67.8%) vs baseline: 📈 +10.4% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ re_group_noaspectTime: ✅ 1.603µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ re_groups_aspectTime: ✅ 3.330µs (SLO: <10.000µs 📉 -66.7%) vs baseline: +7.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.3% ✅ re_groups_noaspectTime: ✅ 1.690µs (SLO: <10.000µs 📉 -83.1%) vs baseline: -0.3% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.7% ✅ re_match_aspectTime: ✅ 3.038µs (SLO: <10.000µs 📉 -69.6%) vs baseline: 📈 +11.5% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.5% ✅ re_match_noaspectTime: ✅ 1.312µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +0.9% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.4% ✅ re_search_aspectTime: ✅ 2.564µs (SLO: <10.000µs 📉 -74.4%) vs baseline: +2.1% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ re_search_noaspectTime: ✅ 1.203µs (SLO: <10.000µs 📉 -88.0%) vs baseline: +0.7% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ re_sub_aspectTime: ✅ 3.561µs (SLO: <10.000µs 📉 -64.4%) vs baseline: +5.9% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.4% ✅ re_sub_noaspectTime: ✅ 1.531µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -0.6% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.3% ✅ re_subn_aspectTime: ✅ 3.718µs (SLO: <10.000µs 📉 -62.8%) vs baseline: +3.4% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +5.6% ✅ re_subn_noaspectTime: ✅ 1.607µs (SLO: <10.000µs 📉 -83.9%) vs baseline: -1.4% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.7% 📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: ~same Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.8% ✅ add_inplace_aspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.7% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.5% ✅ add_inplace_noaspectTime: ✅ 0.320µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.4% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.6% ✅ add_noaspectTime: ✅ 0.274µs (SLO: <10.000µs 📉 -97.3%) vs baseline: +0.4% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.4% ✅ bytearray_aspectTime: ✅ 1.320µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -0.4% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.2% ✅ bytearray_extend_aspectTime: ✅ 1.474µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -3.9% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.3% ✅ bytearray_extend_noaspectTime: ✅ 0.615µs (SLO: <10.000µs 📉 -93.8%) vs baseline: ~same Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.3% ✅ bytearray_noaspectTime: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.6% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.5% ✅ bytes_aspectTime: ✅ 1.301µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +1.1% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.2% ✅ bytes_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 1.358µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +4.4% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.3% ✅ bytesio_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.3% ✅ capitalize_aspectTime: ✅ 0.741µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.1% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.3% ✅ capitalize_noaspectTime: ✅ 0.432µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.1% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.5% ✅ casefold_aspectTime: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.1% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.6% ✅ casefold_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.5% ✅ decode_aspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.3% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +1.0% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.2% ✅ encode_aspectTime: ✅ 0.715µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.2% ✅ encode_noaspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +3.0% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.4% ✅ format_aspectTime: ✅ 3.388µs (SLO: <10.000µs 📉 -66.1%) vs baseline: +2.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.2% ✅ format_map_aspectTime: ✅ 4.206µs (SLO: <10.000µs 📉 -57.9%) vs baseline: 📈 +20.4% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.3% ✅ format_map_noaspectTime: ✅ 0.777µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.5% ✅ format_noaspectTime: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.3% Memory: ✅ 38.162MB (SLO: <39.000MB -2.1%) vs baseline: +5.5% ✅ index_aspectTime: ✅ 0.356µs (SLO: <10.000µs 📉 -96.4%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.2% ✅ index_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: ~same Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.2% ✅ join_aspectTime: ✅ 1.351µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.9% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ join_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.4% ✅ ljust_aspectTime: ✅ 2.486µs (SLO: <20.000µs 📉 -87.6%) vs baseline: -1.1% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.4% ✅ ljust_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.5% ✅ lower_aspectTime: ✅ 2.259µs (SLO: <10.000µs 📉 -77.4%) vs baseline: +3.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.3% ✅ lower_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.4% ✅ lstrip_aspectTime: ✅ 2.219µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.9% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.2% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.7% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.5% ✅ modulo_aspectTime: ✅ 0.986µs (SLO: <10.000µs 📉 -90.1%) vs baseline: -5.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.547µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.3% ✅ modulo_aspect_for_bytesTime: ✅ 0.986µs (SLO: <10.000µs 📉 -90.1%) vs baseline: +1.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.5% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.229µs (SLO: <10.000µs 📉 -87.7%) vs baseline: -0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.3% ✅ modulo_noaspectTime: ✅ 0.626µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.8% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.6% ✅ replace_aspectTime: ✅ 4.757µs (SLO: <10.000µs 📉 -52.4%) vs baseline: -1.7% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.5% ✅ replace_noaspectTime: ✅ 0.459µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.5% ✅ repr_aspectTime: ✅ 0.903µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 0.414µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.1% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.2% ✅ rstrip_aspectTime: ✅ 2.007µs (SLO: <20.000µs 📉 -90.0%) vs baseline: +7.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.3% ✅ rstrip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.4% ✅ slice_aspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.0% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.5% ✅ slice_noaspectTime: ✅ 0.442µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -2.0% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.6% ✅ stringio_aspectTime: ✅ 1.541µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +1.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ stringio_noaspectTime: ✅ 0.721µs (SLO: <10.000µs 📉 -92.8%) vs baseline: ~same Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.2% ✅ strip_aspectTime: ✅ 2.548µs (SLO: <20.000µs 📉 -87.3%) vs baseline: 📈 +14.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.3% ✅ strip_noaspectTime: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.6% ✅ swapcase_aspectTime: ✅ 2.447µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +1.6% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.5% ✅ swapcase_noaspectTime: ✅ 0.538µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.1% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.2% ✅ title_aspectTime: ✅ 2.338µs (SLO: <10.000µs 📉 -76.6%) vs baseline: +0.7% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.5% ✅ title_noaspectTime: ✅ 0.500µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.7% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.3% ✅ translate_aspectTime: ✅ 3.470µs (SLO: <10.000µs 📉 -65.3%) vs baseline: +7.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.5% ✅ translate_noaspectTime: ✅ 1.038µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.2% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.5% ✅ upper_aspectTime: ✅ 2.431µs (SLO: <10.000µs 📉 -75.7%) vs baseline: 📈 +10.4% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.2% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.7% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.5% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.310µs (SLO: <10.000µs 📉 -56.9%) vs baseline: +2.0% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +6.3% ✅ ospathbasename_noaspectTime: ✅ 1.083µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +6.3% ✅ ospathjoin_aspectTime: ✅ 6.052µs (SLO: <10.000µs 📉 -39.5%) vs baseline: -1.6% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +5.6% ✅ ospathjoin_noaspectTime: ✅ 2.298µs (SLO: <10.000µs 📉 -77.0%) vs baseline: -0.3% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +6.4% ✅ ospathnormcase_aspectTime: ✅ 3.535µs (SLO: <10.000µs 📉 -64.7%) vs baseline: +1.6% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +6.2% ✅ ospathnormcase_noaspectTime: ✅ 0.577µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.9% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +6.3% ✅ ospathsplit_aspectTime: ✅ 4.807µs (SLO: <10.000µs 📉 -51.9%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +6.7% ✅ ospathsplit_noaspectTime: ✅ 1.592µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.1% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +6.2% ✅ ospathsplitdrive_aspectTime: ✅ 3.677µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +0.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +6.3% ✅ ospathsplitdrive_noaspectTime: ✅ 0.699µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.7% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +6.3% ✅ ospathsplitext_aspectTime: ✅ 5.309µs (SLO: <10.000µs 📉 -46.9%) vs baseline: 📈 +17.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +6.5% ✅ ospathsplitext_noaspectTime: ✅ 1.390µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +6.3% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.481ms (SLO: <22.300ms -8.2%) vs baseline: ~same Memory: ✅ 66.268MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.343ms (SLO: <1.450ms -7.4%) vs baseline: ~same Memory: ✅ 64.374MB (SLO: <67.000MB -3.9%) vs baseline: +5.2% ✅ iastTime: ✅ 20.420ms (SLO: <22.250ms -8.2%) vs baseline: -0.2% Memory: ✅ 66.273MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.1% ✅ profilerTime: ✅ 15.486ms (SLO: <16.550ms -6.4%) vs baseline: -0.3% Memory: ✅ 54.277MB (SLO: <54.500MB 🟡 -0.4%) vs baseline: +5.4% ✅ resource-renamingTime: ✅ 20.459ms (SLO: <21.750ms -5.9%) vs baseline: -0.2% Memory: ✅ 66.266MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 25.427ms (SLO: <28.200ms -9.8%) vs baseline: +1.6% Memory: ✅ 67.198MB (SLO: <69.500MB -3.3%) vs baseline: +4.3% ✅ tracerTime: ✅ 20.465ms (SLO: <21.750ms -5.9%) vs baseline: -0.3% Memory: ✅ 66.127MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.652ms (SLO: <23.500ms -3.6%) vs baseline: -0.3% Memory: ✅ 68.117MB (SLO: <68.000MB +0.2%) vs baseline: +5.3% ✅ tracer-dont-create-db-spansTime: ✅ 19.337ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.584ms (SLO: <17.500ms -5.2%) vs baseline: -0.5% Memory: ✅ 66.187MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ tracer-nativeTime: ✅ 20.492ms (SLO: <21.750ms -5.8%) vs baseline: +0.3% Memory: ✅ 68.144MB (SLO: <72.500MB -6.0%) vs baseline: +5.4% ✅ tracer-no-cachesTime: ✅ 18.457ms (SLO: <19.650ms -6.1%) vs baseline: -0.4% Memory: ✅ 66.182MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.754ms (SLO: <20.100ms -6.7%) vs baseline: ~same Memory: ✅ 66.157MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.3% ✅ tracer-no-middlewareTime: ✅ 20.120ms (SLO: <21.500ms -6.4%) vs baseline: -0.1% Memory: ✅ 66.293MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.1% ✅ tracer-no-templatesTime: ✅ 20.279ms (SLO: <22.000ms -7.8%) vs baseline: ~same Memory: ✅ 66.179MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.293ms (SLO: <19.850ms -7.8%) vs baseline: +1.0% Memory: ✅ 66.277MB (SLO: <66.500MB 🟡 -0.3%) vs baseline: +5.2% ✅ errortracking-enabled-userTime: ✅ 18.073ms (SLO: <19.400ms -6.8%) vs baseline: +0.5% Memory: ✅ 66.296MB (SLO: <66.500MB 🟡 -0.3%) vs baseline: +5.3% ✅ tracer-enabledTime: ✅ 18.230ms (SLO: <19.450ms -6.3%) vs baseline: +0.9% Memory: ✅ 66.375MB (SLO: <66.500MB 🟡 -0.2%) vs baseline: +5.6% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.074ms (SLO: <2.300ms -9.8%) vs baseline: +0.2% Memory: ✅ 52.730MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 2.074ms (SLO: <2.250ms -7.8%) vs baseline: -0.2% Memory: ✅ 52.612MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.070ms (SLO: <2.300ms 📉 -10.0%) vs baseline: +0.1% Memory: ✅ 52.730MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.2% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.597ms (SLO: <4.750ms -3.2%) vs baseline: -0.1% Memory: ✅ 62.423MB (SLO: <65.000MB -4.0%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.636ms (SLO: <6.750ms 🟡 -1.7%) vs baseline: ~same Memory: ✅ 62.469MB (SLO: <65.000MB -3.9%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.588ms (SLO: <4.750ms -3.4%) vs baseline: -0.4% Memory: ✅ 62.437MB (SLO: <65.000MB -3.9%) vs baseline: +5.1% ✅ debuggerTime: ✅ 1.860ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 45.513MB (SLO: <47.000MB -3.2%) vs baseline: +5.3% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: +0.2% Memory: ✅ 42.298MB (SLO: <49.000MB 📉 -13.7%) vs baseline: +5.1% ✅ profilerTime: ✅ 1.916ms (SLO: <2.100ms -8.8%) vs baseline: ~same Memory: ✅ 46.855MB (SLO: <47.000MB 🟡 -0.3%) vs baseline: +5.2% ✅ resource-renamingTime: ✅ 3.369ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 52.762MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.2% ✅ tracerTime: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: ~same Memory: ✅ 52.675MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 3.349ms (SLO: <3.650ms -8.2%) vs baseline: +0.2% Memory: ✅ 54.529MB (SLO: <60.000MB -9.1%) vs baseline: +5.5% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.964ms (SLO: <4.200ms -5.6%) vs baseline: -0.3% Memory: ✅ 62.482MB (SLO: <66.000MB -5.3%) vs baseline: +5.0% ✅ iast-enabledTime: ✅ 2.441ms (SLO: <2.800ms 📉 -12.8%) vs baseline: -0.7% Memory: ✅ 59.277MB (SLO: <60.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 2.057ms (SLO: <2.250ms -8.6%) vs baseline: -0.2% Memory: ✅ 52.632MB (SLO: <54.500MB -3.4%) vs baseline: +4.8% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 309.102ms (SLO: <320.950ms -3.7%) vs baseline: +0.1% Memory: ✅ 32.952MB (SLO: <34.500MB -4.5%) vs baseline: +5.6% ✅ deep-profiledTime: ✅ 328.005ms (SLO: <359.150ms -8.7%) vs baseline: +0.2% Memory: ✅ 38.350MB (SLO: <39.000MB 🟡 -1.7%) vs baseline: +5.9% ✅ mediumTime: ✅ 7.004ms (SLO: <7.400ms -5.3%) vs baseline: -0.2% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.2% ✅ shallowTime: ✅ 0.939ms (SLO: <1.050ms 📉 -10.5%) vs baseline: ~same Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.4%
|
|
Tests fixed, libdatadog commit be5b5b22039141078d5e125824e338751f2d54a3 (branch avara1986/ffe-pyo3-methods) |
5627047
into
oleksii/libdatadog-24.0.0
|
@avara1986 I have reopened the PR in #15231 |
Reopening #15098 as it was accidentally merged too early. ## Description <!-- Provide an overview of the change and motivation for the change --> Integrate datadog-ffe from libdatadog: DataDog/libdatadog#1289 ## Testing <!-- Describe your testing strategy or note what tests are included --> Tested manually that native bindings work: ``` >>> from ddtrace.internal.native._native import ffe >>> with open("/Users/oleksii.shmalko/dd/libdatadog/datadog-ffe/tests/data/flags-v1.json", 'rb') as f: ... json = f.read() ... >>> config = ffe.Configuration(json) >>> details = config.resolve_value("numeric_flag", ffe.FlagType.Float, {}) >>> details.variant 'pi' >>> details.value 3.1415926 ``` More testing will be done as part of FFE feature. ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> This PR is stacked against #15219 --------- Co-authored-by: Alberto Vara <alberto.vara@datadoghq.com>
Description
Integrate datadog-ffe from libdatadog: DataDog/libdatadog#1289
Testing
Tested manually that native bindings work:
More testing will be done as part of FFE feature.
Risks
Additional Notes
This PR is stacked against #15219