-
Notifications
You must be signed in to change notification settings - Fork 469
chore(writer): enable native writer by default #15230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(writer): enable native writer by default #15230
Conversation
Enabling the native writer increase the memory usage due to the inefficient double serialization used to pass traces.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 247 ± 2 ms. The average import time from base is: 241 ± 2 ms. The import time difference between this PR and base is: 6.14 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate vianney/enable-native-writer-by-default (ab67b86) with baseline 3.19 (a25be14) 📈 Performance Regressions (20 suites)📈 coreapiscenario - 10/10 (1 unstable)
|
## Description <!-- Provide an overview of the change and motivation for the change --> ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers -->
2721fa0 to
bbddcd4
Compare
7f443a4 to
d562aeb
Compare
d562aeb to
9dfe486
Compare
Description
Enables the native writer by default. The native writer can still be disabled through _DD_TRACE_WRITER_NATIVE.
Testing
All tests are run with the native writer. The native writer have also been enabled on some services internally for dogfooding purposes.
Risks
This changes the logic behind trace export and client-side stats computation (for customers who enabled it). We expect no change in behavior for trace exporting. Client-side stats behavior may show some differences as the current python implementation is not fully compliant with the client-side stats spec.