-
Notifications
You must be signed in to change notification settings - Fork 469
chore(tornado): v4.0 deprecations [backport 3.19] #15303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.19
Are you sure you want to change the base?
Conversation
|
|
Deprecated Tornado versions older than v6.1 and programmatic configuration via ddtrace.contrib.tornado. Users should upgrade to Tornado v6.1+ and use environment variables with import ddtrace.auto. Tornado v6.1 (released in 2020) added contextvars support, eliminating the need for a custom Tornado Context Provider. This allows us to remove the last integration specific Context Provider and simplify our context API. --------- Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit 75a19c2)
6937a46 to
c007653
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 250 ± 3 ms. The average import time from base is: 251 ± 2 ms. The import time difference between this PR and base is: -1.2 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate backport-15274-to-3.19 (401fc99) with baseline 3.19 (6f9f4af) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.541µs (SLO: <10.000µs 📉 -54.6%) vs baseline: +5.8% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 1.084µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.5% Memory: ✅ 39.695MB (SLO: <41.000MB -3.2%) vs baseline: +4.4% ✅ ospathjoin_aspectTime: ✅ 7.162µs (SLO: <10.000µs 📉 -28.4%) vs baseline: 📈 +15.3% Memory: ✅ 39.833MB (SLO: <41.000MB -2.8%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.314µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +1.3% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.581µs (SLO: <10.000µs 📉 -64.2%) vs baseline: -1.3% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.567µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.5% Memory: ✅ 39.833MB (SLO: <41.000MB -2.8%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.847µs (SLO: <10.000µs 📉 -51.5%) vs baseline: +0.2% Memory: ✅ 39.774MB (SLO: <41.000MB -3.0%) vs baseline: +4.5% ✅ ospathsplit_noaspectTime: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.3% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 4.085µs (SLO: <10.000µs 📉 -59.2%) vs baseline: +8.9% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.700µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.9% Memory: ✅ 39.774MB (SLO: <41.000MB -3.0%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.607µs (SLO: <10.000µs 📉 -53.9%) vs baseline: ~same Memory: ✅ 39.833MB (SLO: <41.000MB -2.8%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.373µs (SLO: <10.000µs 📉 -86.3%) vs baseline: ~same Memory: ✅ 39.911MB (SLO: <41.000MB -2.7%) vs baseline: +5.0% 🟡 Near SLO Breach (2 suites)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.600ms (SLO: <4.750ms -3.1%) vs baseline: +0.2% Memory: ✅ 64.252MB (SLO: <66.500MB -3.4%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.626ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: -0.4% Memory: ✅ 64.348MB (SLO: <66.500MB -3.2%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.586ms (SLO: <4.750ms -3.5%) vs baseline: -0.3% Memory: ✅ 64.198MB (SLO: <66.500MB -3.5%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.2%) vs baseline: -0.4% Memory: ✅ 47.809MB (SLO: <49.500MB -3.4%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.1% Memory: ✅ 44.640MB (SLO: <49.000MB -8.9%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: -0.6% Memory: ✅ 48.803MB (SLO: <50.000MB -2.4%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.371ms (SLO: <3.650ms -7.7%) vs baseline: +0.2% Memory: ✅ 54.607MB (SLO: <56.000MB -2.5%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: +0.1% Memory: ✅ 54.581MB (SLO: <56.500MB -3.4%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: -0.1% Memory: ✅ 54.595MB (SLO: <60.000MB -9.0%) vs baseline: +4.8% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.961µs (SLO: <20.000µs 📉 -85.2%) vs baseline: -0.3% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 201.437µs (SLO: <220.000µs -8.4%) vs baseline: -0.3% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.249µs (SLO: <20.000µs 📉 -83.8%) vs baseline: -0.5% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 211.407µs (SLO: <220.000µs -3.9%) vs baseline: -1.6% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.169µs (SLO: <20.000µs 📉 -89.2%) vs baseline: ~same Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.151µs (SLO: <150.000µs -8.6%) vs baseline: +0.2% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.084µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +0.1% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 217.170µs (SLO: <250.000µs 📉 -13.1%) vs baseline: +0.8% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.383ms (SLO: <22.000ms -7.3%) vs baseline: -1.2% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.260ms (SLO: <2.300ms 🟡 -1.8%) vs baseline: +1.3% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.403ms (SLO: <1.550ms -9.5%) vs baseline: ~same Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.214ms (SLO: <2.550ms 📉 -13.2%) vs baseline: -0.8% Memory: ✅ 34.406MB (SLO: <35.500MB -3.1%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.523µs (SLO: <20.000µs 📉 -77.4%) vs baseline: +1.1% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 175.440µs (SLO: <250.000µs 📉 -29.8%) vs baseline: -0.5% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.128ms (SLO: <2.500ms 📉 -14.9%) vs baseline: ~same Memory: ✅ 35.252MB (SLO: <36.500MB -3.4%) vs baseline: +5.1%
|
Backport 75a19c2 from #15274 to 3.19.
Description
Deprecated Tornado versions older than v6.1 and programmatic configuration via ddtrace.contrib.tornado. Users should upgrade to Tornado v6.1+ and use environment variables with import ddtrace.auto.
Motivation
Tornado v6.1 (released in 2020) added contextvars support, eliminating the need for a custom Tornado Context Provider. This allows us to remove the last integration specific Context Provider and simplify our context API.