-
Notifications
You must be signed in to change notification settings - Fork 469
chore(tornado): drop support for <v6.1 #15305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6a22ddc to
c0fa851
Compare
|
|
c0fa851 to
88fd5d3
Compare
88fd5d3 to
951e12a
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 271 ± 6 ms. The average import time from base is: 270 ± 8 ms. The import time difference between this PR and base is: 0.4 ± 0.3 ms. The difference is not statistically significant (z = 1.21). Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate munir/remove-tornado-stuff (951e12a) with baseline main (60a975f) 🟡 Near SLO Breach (3 suites)🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.580ms (SLO: <47.150ms 📉 -18.2%) vs baseline: ~same Memory: ✅ 39.048MB (SLO: <47.000MB 📉 -16.9%) vs baseline: +5.2% ✅ add-metricsTime: ✅ 257.561ms (SLO: <344.800ms 📉 -25.3%) vs baseline: +0.2% Memory: ✅ 43.333MB (SLO: <47.500MB -8.8%) vs baseline: +5.2% ✅ add-tagsTime: ✅ 314.707ms (SLO: <321.000ms 🟡 -2.0%) vs baseline: ~same Memory: ✅ 43.374MB (SLO: <47.500MB -8.7%) vs baseline: +5.2% ✅ get-contextTime: ✅ 78.865ms (SLO: <92.350ms 📉 -14.6%) vs baseline: +1.0% Memory: ✅ 39.315MB (SLO: <46.500MB 📉 -15.5%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 35.833ms (SLO: <44.500ms 📉 -19.5%) vs baseline: -0.4% Memory: ✅ 38.958MB (SLO: <47.500MB 📉 -18.0%) vs baseline: +5.4% ✅ record-exceptionTime: ✅ 56.639ms (SLO: <67.650ms 📉 -16.3%) vs baseline: -0.2% Memory: ✅ 39.392MB (SLO: <47.000MB 📉 -16.2%) vs baseline: +4.8% ✅ set-statusTime: ✅ 42.494ms (SLO: <50.400ms 📉 -15.7%) vs baseline: +0.5% Memory: ✅ 38.886MB (SLO: <47.000MB 📉 -17.3%) vs baseline: +5.2% ✅ startTime: ✅ 35.445ms (SLO: <43.450ms 📉 -18.4%) vs baseline: +0.1% Memory: ✅ 38.699MB (SLO: <47.000MB 📉 -17.7%) vs baseline: +4.4% ✅ start-finishTime: ✅ 82.027ms (SLO: <88.000ms -6.8%) vs baseline: +0.6% Memory: ✅ 36.451MB (SLO: <46.500MB 📉 -21.6%) vs baseline: +4.5% ✅ start-finish-telemetryTime: ✅ 83.626ms (SLO: <89.000ms -6.0%) vs baseline: +0.3% Memory: ✅ 36.569MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +5.1% ✅ update-nameTime: ✅ 37.003ms (SLO: <45.150ms 📉 -18.0%) vs baseline: ~same Memory: ✅ 38.928MB (SLO: <47.000MB 📉 -17.2%) vs baseline: +5.0% 🟡 packagespackageforrootmodulemapping - 4/4✅ cache_offTime: ✅ 341.608ms (SLO: <354.300ms -3.6%) vs baseline: -0.7% Memory: ✅ 41.327MB (SLO: <41.500MB 🟡 -0.4%) vs baseline: +6.4% ✅ cache_onTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.2% Memory: ✅ 39.280MB (SLO: <41.000MB -4.2%) vs baseline: +4.8% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.900µs (SLO: <20.000µs 📉 -85.5%) vs baseline: -1.0% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.5% ✅ 1-count-metrics-100-timesTime: ✅ 198.610µs (SLO: <220.000µs -9.7%) vs baseline: ~same Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.356µs (SLO: <20.000µs 📉 -83.2%) vs baseline: +1.9% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.900µs (SLO: <220.000µs 🟡 -1.9%) vs baseline: -0.2% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.184µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.9% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.094µs (SLO: <150.000µs -8.6%) vs baseline: +0.2% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.120µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +1.4% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 212.406µs (SLO: <250.000µs 📉 -15.0%) vs baseline: ~same Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.4% ✅ 100-count-metrics-100-timesTime: ✅ 20.194ms (SLO: <22.000ms -8.2%) vs baseline: +1.2% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.269ms (SLO: <2.300ms 🟡 -1.4%) vs baseline: +0.6% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.1%) vs baseline: +0.1% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.197ms (SLO: <2.550ms 📉 -13.9%) vs baseline: +1.0% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 4.629µs (SLO: <20.000µs 📉 -76.9%) vs baseline: +0.6% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.2% ✅ flush-100-metricsTime: ✅ 174.241µs (SLO: <250.000µs 📉 -30.3%) vs baseline: ~same Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.1% ✅ flush-1000-metricsTime: ✅ 2.123ms (SLO: <2.500ms 📉 -15.1%) vs baseline: +0.3% Memory: ✅ 35.252MB (SLO: <36.500MB -3.4%) vs baseline: +4.6%
|
Description
Updated Tornado minimum supported version to v6.1+ and migrated to
contextvars-based context management. Removed the custom stack-based context provider previously required for older Tornado versions.Testing
Existing Tornado integration tests pass with v6.1+.
Risks
Low. Tornado v6.1 released in 2020.
Additional Notes
Unifies context management across all ddtrace integrations and simplifies the codebase.