Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reno to Riot #2931

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Add Reno to Riot #2931

merged 3 commits into from
Oct 21, 2021

Conversation

mtoffl01
Copy link
Contributor

Added a Venv for reno in the riotfile. Documented the use of reno to create release notes, for contributors.

@mtoffl01 mtoffl01 requested a review from a team as a code owner October 20, 2021 20:03
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@@ -1252,5 +1252,13 @@ def select_pys(min_version=MIN_PYTHON_VERSION, max_version=MAX_PYTHON_VERSION):
),
],
),
Venv(
pys=["3"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have all pys selected, does not that run the command for every python version? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, but here we have just "3", which ends up running whatever version python3 refers to.

@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 21, 2021
Copy link
Contributor

@P403n1x87 P403n1x87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@mergify mergify bot merged commit c44ccc7 into master Oct 21, 2021
@mergify mergify bot deleted the mtoff/add-reno-to-riot branch October 21, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants