Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vendor): fix psutil getpagesize() for newer macos #3382

Merged
merged 1 commit into from
Mar 7, 2022
Merged

chore(vendor): fix psutil getpagesize() for newer macos #3382

merged 1 commit into from
Mar 7, 2022

Conversation

brettlangdon
Copy link
Member

Newer versions of macos do not have getpagesize(), and instead PAGE_SIZE should be used.

giampaolo/psutil#1794

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 7, 2022
@brettlangdon brettlangdon requested a review from a team as a code owner March 7, 2022 14:20
@brettlangdon
Copy link
Member Author

@Mergifyio backport 0.x

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2022

backport 0.x

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Kyle-Verhoog
Kyle-Verhoog approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even use these functions? Wonder if it's worth just trimming down our vendored psutil instead rather than trying to maintain all this code.

@brettlangdon
Copy link
Member Author

Do we even use these functions? Wonder if it's worth just trimming down our vendored psutil instead rather than trying to maintain all this code.

This is a great question. I actually don't know, but definitely worth looking into

@mergify mergify bot merged commit d9b9ad8 into 1.x Mar 7, 2022
@mergify mergify bot deleted the brettlangdon/fix.psutil.osx branch March 7, 2022 18:44
mergify bot pushed a commit that referenced this pull request Mar 7, 2022
@brettlangdon
chore(vendor): fix psutil getpagesize() for newer macos (#3382)
7d2d75e 
Newer versions of macos do not have `getpagesize()`, and instead `PAGE_SIZE` should be used.

giampaolo/psutil#1794
(cherry picked from commit d9b9ad8)
@mergify mergify bot mentioned this pull request Mar 7, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2022

backport 0.x

✅ Backports have been created

brettlangdon added a commit that referenced this pull request Mar 7, 2022
@brettlangdon
fix(docs): add release note missing from #3382
b2fd4e3
@brettlangdon brettlangdon mentioned this pull request Mar 7, 2022
Merged
brettlangdon added a commit that referenced this pull request Mar 7, 2022
@mergify @brettlangdon
chore(vendor): fix psutil getpagesize() for newer macos (#3382) (#3385)
b854fc2 
Newer versions of macos do not have `getpagesize()`, and instead `PAGE_SIZE` should be used.

giampaolo/psutil#1794
(cherry picked from commit d9b9ad8)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
@brettlangdon brettlangdon added this to the v1.0.0 milestone Mar 7, 2022
@brettlangdon
Copy link
Member Author

@Mergifyio backport 1.0

@brettlangdon brettlangdon modified the milestones: v1.0.0, v1.1.0 Mar 7, 2022
mergify bot added a commit that referenced this pull request Mar 7, 2022
@mergify
chore(vendor): fix psutil getpagesize() for newer macos (#3382) (#3385)
0c01cb4 
Newer versions of macos do not have `getpagesize()`, and instead `PAGE_SIZE` should be used.

giampaolo/psutil#1794
(cherry picked from commit d9b9ad8)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit b854fc2)
mergify bot pushed a commit that referenced this pull request Mar 7, 2022
@brettlangdon
chore(vendor): fix psutil getpagesize() for newer macos (#3382)
ed30206 
Newer versions of macos do not have `getpagesize()`, and instead `PAGE_SIZE` should be used.

giampaolo/psutil#1794
(cherry picked from commit d9b9ad8)
@mergify mergify bot mentioned this pull request Mar 7, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2022

backport 1.0

✅ Backports have been created

brettlangdon added a commit that referenced this pull request Mar 8, 2022
@brettlangdon
fix(docs): add release note missing from #3382 (#3387)
ab54272 
* fix(docs): add release note missing from #3382

* chore(docs): add macOS to spelling list
mergify bot pushed a commit that referenced this pull request Mar 8, 2022
@brettlangdon
fix(docs): add release note missing from #3382 (#3387)
6177cd8 
* fix(docs): add release note missing from #3382

* chore(docs): add macOS to spelling list

(cherry picked from commit ab54272)
brettlangdon pushed a commit that referenced this pull request Mar 8, 2022
@mergify
chore(vendor): fix psutil getpagesize() for newer macos (#3382) (#3385)…
f229c0d 
… (#3388)

Newer versions of macos do not have `getpagesize()`, and instead `PAGE_SIZE` should be used.

giampaolo/psutil#1794
(cherry picked from commit d9b9ad8)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit b854fc2)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
brettlangdon added a commit that referenced this pull request Mar 8, 2022
@mergify @brettlangdon
chore(vendor): fix psutil getpagesize() for newer macos (#3382) (#3389)
f20b90d 
Newer versions of macos do not have `getpagesize()`, and instead `PAGE_SIZE` should be used.

giampaolo/psutil#1794
(cherry picked from commit d9b9ad8)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon added a commit that referenced this pull request Mar 8, 2022
@brettlangdon
fix(docs): add release note missing from #3382 (#3387)
336772b 
* fix(docs): add release note missing from #3382

* chore(docs): add macOS to spelling list

(cherry picked from commit ab54272)
brettlangdon added a commit that referenced this pull request Mar 8, 2022
@mergify @brettlangdon
fix(docs): add release note missing from #3382 (#3387) (#3391)
9aa0ba0 
* fix(docs): add release note missing from #3382

* chore(docs): add macOS to spelling list

(cherry picked from commit ab54272)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon added a commit that referenced this pull request Mar 8, 2022
@brettlangdon
fix(docs): add release note missing from #3382 (#3387)
c8c759b 
* fix(docs): add release note missing from #3382

* chore(docs): add macOS to spelling list

(cherry picked from commit ab54272)
brettlangdon added a commit that referenced this pull request Mar 8, 2022
@mergify @brettlangdon
fix(docs): add release note missing from #3382 (#3387) (#3390)
479b253 
* fix(docs): add release note missing from #3382

* chore(docs): add macOS to spelling list

(cherry picked from commit ab54272)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon added a commit that referenced this pull request Mar 8, 2022
@mergify @brettlangdon
fix(docs): add release note missing from #3382 (#3387) (#3392)
1aca997 
* fix(docs): add release note missing from #3382

* chore(docs): add macOS to spelling list

(cherry picked from commit ab54272)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

@majorgreys majorgreys majorgreys approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brettlangdon @majorgreys @Kyle-Verhoog