fix(ci): pin importlib_metadata<5.0.0 #4257

majorgreys · 2022-10-03T16:59:14Z

CI jobs profile-windows-*, kombu and celery are failing due to the release of importlib_metadata==5.0.0 which removed deprecated shims, resulting in the following exception:

AttributeError: 'EntryPoints' object has no attribute 'get'

We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox.

Kyle-Verhoog

Can we describe why we need to pin in the PR description?

majorgreys · 2022-10-03T17:38:41Z

This PR or #4253 will need to be force merged to unblock #4252.

cc @Kyle-Verhoog @brettlangdon

majorgreys · 2022-10-03T18:02:37Z

@Mergifyio backport 1.5 1.4 0.61

mergify · 2022-10-03T18:03:11Z

backport 1.5 1.4 0.x 0.61

✅ Backports have been created

#4286 fix(ci): pin importlib_metadata<5.0.0 (backport #4257) has been created for branch 1.5
#4287 fix(ci): pin importlib_metadata<5.0.0 (backport #4257) has been created for branch 1.4
#4288 fix(ci): pin importlib_metadata<5.0.0 (backport #4257) has been created for branch 0.x
#4289 fix(ci): pin importlib_metadata<5.0.0 (backport #4257) has been created for branch 0.61

Kyle-Verhoog · 2022-10-03T18:25:47Z

https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21692/workflows/9e343c62-7932-40fb-80b3-4de4473d7eed/jobs/1477305 looks like it's still failing 🤔

jd · 2022-10-04T07:22:09Z

It'd be great to track the upstream issue (I imagine it's one of the dependencies we pull that breaks with 5.0.0, not our code).

majorgreys · 2022-10-04T12:11:48Z

It'd be great to track the upstream issue (I imagine it's one of the dependencies we pull that breaks with 5.0.0, not our code).

Added open issue on the breaking change.

mergify · 2022-10-04T20:56:55Z

backport 1.5 1.4 0.61

✅ Backports have been created

#4286 fix(ci): pin importlib_metadata<5.0.0 (backport #4257) has been created for branch 1.5
#4287 fix(ci): pin importlib_metadata<5.0.0 (backport #4257) has been created for branch 1.4
#4289 fix(ci): pin importlib_metadata<5.0.0 (backport #4257) has been created for branch 0.61

majorgreys · 2022-10-05T21:01:03Z

As a follow-up, we can look into enabling the profile-windows jobs with the updated image.

cc @jd

Kyle-Verhoog

🙌 for dealing with this mess @majorgreys!!

.circleci/config.yml

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>

CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e)

CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) # Conflicts: # .circleci/config.yml

CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>

CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

mabdinur · 2022-10-19T14:57:43Z

@Mergifyio backport 0.61

mergify · 2022-10-19T14:58:16Z

backport 0.61

✅ Backports have been created

#4289 fix(ci): pin importlib_metadata<5.0.0 (backport #4257) has been created for branch 0.61

* fix(ci): pin importlib_metadata<5.0.0 (#4257) CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) # Conflicts: # .circleci/config.yml * fix conflicts Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com>

fix(ci): pin importlib_metadata<5.0.0

c16f583

majorgreys added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 3, 2022

majorgreys requested a review from a team as a code owner October 3, 2022 16:59

Kyle-Verhoog previously approved these changes Oct 3, 2022

View reviewed changes

mabdinur previously approved these changes Oct 3, 2022

View reviewed changes

Yun-Kim previously approved these changes Oct 3, 2022

View reviewed changes

Merge branch '1.x' into majorgreys/ci-pin-importlib

0e396e0

mergify bot added 3 commits October 3, 2022 21:42

Merge branch '1.x' into majorgreys/ci-pin-importlib

d2bd83c

Merge branch '1.x' into majorgreys/ci-pin-importlib

d206fa4

Merge branch '1.x' into majorgreys/ci-pin-importlib

c2f0c08

jd previously approved these changes Oct 4, 2022

View reviewed changes

mergify bot added 3 commits October 4, 2022 13:48

Merge branch '1.x' into majorgreys/ci-pin-importlib

58f1f0b

Merge branch '1.x' into majorgreys/ci-pin-importlib

d4583bd

Merge branch '1.x' into majorgreys/ci-pin-importlib

9a00bfa

majorgreys force-pushed the majorgreys/ci-pin-importlib branch from 47b6a59 to 21509fe Compare October 5, 2022 14:18

Merge branch '1.x' into majorgreys/ci-pin-importlib

785976d

majorgreys force-pushed the majorgreys/ci-pin-importlib branch from 21509fe to 785976d Compare October 5, 2022 14:25

use simpler version

5edda43

majorgreys dismissed stale reviews from jd, Yun-Kim, mabdinur, and Kyle-Verhoog via 5edda43 October 5, 2022 14:28

majorgreys force-pushed the majorgreys/ci-pin-importlib branch from 392f750 to 81e4de2 Compare October 5, 2022 17:35

majorgreys force-pushed the majorgreys/ci-pin-importlib branch from a29a762 to 1830fc6 Compare October 5, 2022 19:31

mabdinur previously approved these changes Oct 5, 2022

View reviewed changes

brettlangdon previously approved these changes Oct 5, 2022

View reviewed changes

Kyle-Verhoog previously approved these changes Oct 5, 2022

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

Update .circleci/config.yml

50d4619

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>

majorgreys dismissed stale reviews from Kyle-Verhoog, brettlangdon, and mabdinur via 50d4619 October 5, 2022 21:14

majorgreys requested review from Kyle-Verhoog, brettlangdon and mabdinur October 5, 2022 21:14

mabdinur approved these changes Oct 5, 2022

View reviewed changes

Kyle-Verhoog approved these changes Oct 5, 2022

View reviewed changes

mergify bot merged commit c2b416e into 1.x Oct 6, 2022

mergify bot deleted the majorgreys/ci-pin-importlib branch October 6, 2022 00:51

mergify bot mentioned this pull request Oct 6, 2022

fix(ci): pin importlib_metadata<5.0.0 (backport #4257) #4286

Merged

This was referenced Oct 6, 2022

fix(ci): pin importlib_metadata<5.0.0 (backport #4257) #4287

Merged

fix(ci): pin importlib_metadata<5.0.0 (backport #4257) #4288

Closed

github-actions bot added this to the v1.6.0 milestone Oct 6, 2022

mergify bot mentioned this pull request Oct 6, 2022

fix(ci): pin importlib_metadata<5.0.0 (backport #4257) #4289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): pin importlib_metadata<5.0.0 #4257

fix(ci): pin importlib_metadata<5.0.0 #4257

majorgreys commented Oct 3, 2022 •

edited

Loading

Kyle-Verhoog left a comment

majorgreys commented Oct 3, 2022

majorgreys commented Oct 3, 2022 •

edited by mabdinur

Loading

mergify bot commented Oct 3, 2022 •

edited

Loading

Kyle-Verhoog commented Oct 3, 2022

jd commented Oct 4, 2022

majorgreys commented Oct 4, 2022

mergify bot commented Oct 4, 2022 •

edited

Loading

majorgreys commented Oct 5, 2022

Kyle-Verhoog left a comment

mabdinur commented Oct 19, 2022

mergify bot commented Oct 19, 2022

fix(ci): pin importlib_metadata<5.0.0 #4257

fix(ci): pin importlib_metadata<5.0.0 #4257

Conversation

majorgreys commented Oct 3, 2022 • edited Loading

Kyle-Verhoog left a comment

Choose a reason for hiding this comment

majorgreys commented Oct 3, 2022

majorgreys commented Oct 3, 2022 • edited by mabdinur Loading

mergify bot commented Oct 3, 2022 • edited Loading

✅ Backports have been created

Kyle-Verhoog commented Oct 3, 2022

jd commented Oct 4, 2022

majorgreys commented Oct 4, 2022

mergify bot commented Oct 4, 2022 • edited Loading

✅ Backports have been created

majorgreys commented Oct 5, 2022

Kyle-Verhoog left a comment

Choose a reason for hiding this comment

mabdinur commented Oct 19, 2022

mergify bot commented Oct 19, 2022

✅ Backports have been created

majorgreys commented Oct 3, 2022 •

edited

Loading

majorgreys commented Oct 3, 2022 •

edited by mabdinur

Loading

mergify bot commented Oct 3, 2022 •

edited

Loading

mergify bot commented Oct 4, 2022 •

edited

Loading