Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(mypy): remove type callable ignores (backport #4253) #4261

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 3, 2022

This is an automatic backport of pull request #4253 done by Mergify.
Cherry-pick of 0ba3e29 has failed:

On branch mergify/bp/0.61/pr-4253
Your branch is up to date with 'origin/0.61'.

You are currently cherry-picking commit 0ba3e299.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ddtrace/profiling/collector/__init__.py
	both modified:   ddtrace/profiling/collector/memalloc.py
	both modified:   ddtrace/profiling/exporter/http.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI.

(cherry picked from commit 0ba3e29)

# Conflicts:
#	ddtrace/profiling/collector/__init__.py
#	ddtrace/profiling/collector/memalloc.py
#	ddtrace/profiling/exporter/http.py
@mergify mergify bot requested a review from a team as a code owner October 3, 2022 18:01
@mergify mergify bot added the conflicts label Oct 3, 2022
@mergify mergify bot mentioned this pull request Oct 3, 2022
14 tasks
@mergify mergify bot removed the conflicts label Oct 3, 2022
@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 3, 2022
@Yun-Kim
Copy link
Contributor

Yun-Kim commented Oct 3, 2022

Closing as fix is unnecessary.

@Yun-Kim Yun-Kim closed this Oct 3, 2022
@mergify mergify bot deleted the mergify/bp/0.61/pr-4253 branch October 3, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant