chore(iast): remote config thread workaround for gevent #4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnufede
added
changelog/no-changelog
…ter-thread-starts-workaround-wip
…ter-thread-starts-workaround-wip
P403n1x87
reviewed
Dec 9, 2022
christophe-papazian
previously approved these changes
Dec 12, 2022
gnufede
force-pushed
the
gnufede/APPSEC-6558-start-rcm-thread-when-writer-thread-starts-workaround-wip
branch
from
3466dcf to
d64eec9
Compare
…art-rcm-thread-when-writer-thread-starts-workaround-wip
Codecov Report
@@ Coverage Diff @@
## 1.x #4749 +/- ##
=======================================
Coverage 74.55% 74.55%
=======================================
Files 812 812
Lines 62131 62131
=======================================
Hits 46324 46324
Misses 15807 15807
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ter-thread-starts-workaround-wip
gnufede
force-pushed
the
gnufede/APPSEC-6558-start-rcm-thread-when-writer-thread-starts-workaround-wip
branch
4 times, most recently
from
ea10d46 to
a12984a
Compare
gnufede
force-pushed
the
gnufede/APPSEC-6558-start-rcm-thread-when-writer-thread-starts-workaround-wip
branch
from
a12984a to
f732779
Compare
…ter-thread-starts-workaround-wip
christophe-papazian
previously approved these changes
Dec 20, 2022
juanjux
previously approved these changes
Dec 20, 2022
P403n1x87
previously approved these changes
Dec 20, 2022
gnufede
dismissed stale reviews from P403n1x87, juanjux, and christophe-papazian
via
ac9d7b6
…ter-thread-starts-workaround-wip
brettlangdon
approved these changes
Dec 20, 2022
avara1986
approved these changes
Dec 21, 2022
gnufede
deleted the
gnufede/APPSEC-6558-start-rcm-thread-when-writer-thread-starts-workaround-wip
branch
gnufede
added a commit
that referenced
this pull request
Dec 22, 2022
## Description Workaround for remote config to work properly with gevent. This PR ensures the Remote config worker thread is launched at the very end, not interrupting the gevent patching mechanism. Without this PR, the gevent patching is interrupted so if gevent is used, it won't work as expected. As a side effect, if gevent is used and Django is installed, our Django patching mechanism collides with gevent raising a Django ImproperlyConfigured error. ## Checklist - [ ] Followed the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) when writing a release note. - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added and follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines), or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio.
gnufede
added a commit
that referenced
this pull request
Dec 22, 2022
## Description Workaround for remote config to work properly with gevent. This PR ensures the Remote config worker thread is launched at the very end, not interrupting the gevent patching mechanism. Without this PR, the gevent patching is interrupted so if gevent is used, it won't work as expected. As a side effect, if gevent is used and Django is installed, our Django patching mechanism collides with gevent raising a Django ImproperlyConfigured error. ## Checklist - [ ] Followed the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) when writing a release note. - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added and follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines), or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio.
11 tasks
mabdinur
pushed a commit
that referenced
this pull request
Dec 23, 2022
… to 1.7] (#4824) ## Description Workaround for remote config to work properly with gevent. This PR ensures the Remote config worker thread is launched at the very end, not interrupting the gevent patching mechanism. Without this PR, the gevent patching is interrupted so if gevent is used, it won't work as expected. As a side effect, if gevent is used and Django is installed, our Django patching mechanism collides with gevent raising a Django ImproperlyConfigured error. ## Checklist - [ ] Followed the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) when writing a release note. - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added and follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines), or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workaround for remote config to work properly with gevent.
This PR ensures the Remote config worker thread is launched at the very end, not interrupting the gevent patching mechanism.
Without this PR, the gevent patching is interrupted so if gevent is used, it won't work as expected.
As a side effect, if gevent is used and Django is installed, our Django patching mechanism collides with gevent raising a Django ImproperlyConfigured error.
Checklist
featandfixpull requests.Reviewer Checklist
changelog/no-changeloglabel added.