-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(debugging): ensure correct log probe configuration handling #5143
Merged
P403n1x87
merged 8 commits into
DataDog:1.x
from
P403n1x87:chore/debugger-ensure-log-probe-config-handling
Feb 24, 2023
Merged
chore(debugging): ensure correct log probe configuration handling #5143
P403n1x87
merged 8 commits into
DataDog:1.x
from
P403n1x87:chore/debugger-ensure-log-probe-config-handling
Feb 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the RCM adapter for dynamic instrumentation can parse the payload attributes correctly.
38432f9
to
24c0a5f
Compare
shatzi
previously approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. nice refactoring
emmettbutler
previously approved these changes
Feb 22, 2023
Codecov Report
@@ Coverage Diff @@
## 1.x #5143 +/- ##
==========================================
+ Coverage 76.50% 76.52% +0.01%
==========================================
Files 863 863
Lines 66372 66382 +10
==========================================
+ Hits 50781 50801 +20
+ Misses 15591 15581 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shatzi
reviewed
Feb 23, 2023
P403n1x87
commented
Feb 23, 2023
shatzi
previously approved these changes
Feb 23, 2023
shatzi
approved these changes
Feb 23, 2023
emmettbutler
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
A changelog entry is not required for this PR.
Dynamic Instrumentation
Dynamic Instrumentation/Live Debugger
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the RCM adapter for dynamic instrumentation can parse the payload attributes correctly.
Checklist
Reviewer Checklist