Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(debugging): ensure correct log probe configuration handling #5143

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Feb 16, 2023

This change ensures that the RCM adapter for dynamic instrumentation can parse the payload attributes correctly.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Author is aware of the performance implications of this PR as reported in the benchmarks PR comment.

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer is aware of, and discussed the performance implications of this PR as reported in the benchmarks PR comment.

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Feb 16, 2023
@P403n1x87 P403n1x87 requested a review from a team as a code owner February 16, 2023 16:28
This change ensures that the RCM adapter for dynamic instrumentation
can parse the payload attributes correctly.
@P403n1x87 P403n1x87 force-pushed the chore/debugger-ensure-log-probe-config-handling branch from 38432f9 to 24c0a5f Compare February 16, 2023 16:29
@P403n1x87 P403n1x87 enabled auto-merge (squash) February 16, 2023 16:29
shatzi
shatzi previously approved these changes Feb 16, 2023
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. nice refactoring

emmettbutler
emmettbutler previously approved these changes Feb 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5143 (aaeabe2) into 1.x (6302bed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              1.x    #5143      +/-   ##
==========================================
+ Coverage   76.50%   76.52%   +0.01%     
==========================================
  Files         863      863              
  Lines       66372    66382      +10     
==========================================
+ Hits        50781    50801      +20     
+ Misses      15591    15581      -10     
Impacted Files Coverage Δ
ddtrace/debugging/_probe/model.py 97.82% <100.00%> (+0.04%) ⬆️
ddtrace/debugging/_probe/remoteconfig.py 91.66% <100.00%> (+8.95%) ⬆️
tests/debugging/probe/test_remoteconfig.py 97.87% <100.00%> (+0.19%) ⬆️
ddtrace/internal/telemetry/writer.py 38.02% <0.00%> (-1.41%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@P403n1x87 P403n1x87 dismissed stale reviews from emmettbutler and shatzi via e9f96a5 February 23, 2023 15:17
shatzi
shatzi previously approved these changes Feb 23, 2023
@P403n1x87 P403n1x87 merged commit 4f88161 into DataDog:1.x Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants