Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): ensure instrumentation telemetry client is consistent across major versions #6880

Closed
wants to merge 1 commit into from

Commits on Sep 11, 2023

  1. chore(telemetry): ensure instrumentation telemetry is compatible with…

    … python 3.12 (#6859)
    
    - Make the instrumentation telemetry client compatible with python3.12:
    python/cpython#104826
    
     - Start telemetry worker thread as early as possible.
     - Delays sending all telemetry events until app-started is queued.
     - Refactors tests to align with this new logic.
    
    - Telemetry events (metrics/logs/integrations) are queued as early as
    possible but these events are only sent when the trace agent writer is
    started. This **may** result in a memory leak if high cardinality
    telemetry metrics and logs are added in the future. This is not a
    concern right now.
    
    - [x] Change(s) are motivated and described in the PR description.
    - [x] Testing strategy is described if automated tests are not included
    in the PR.
    - [x] Risk is outlined (performance impact, potential for breakage,
    maintainability, etc).
    - [x] Change is maintainable (easy to change, telemetry, documentation).
    - [x] [Library release note
    guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
    are followed. If no release note is required, add label
    `changelog/no-changelog`.
    - [x] Documentation is included (in-code, generated user docs, [public
    corp docs](https://github.com/DataDog/documentation/)).
    - [x] Backport labels are set (if
    [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
    
    - [x] Title is accurate.
    - [x] No unnecessary changes are introduced.
    - [x] Description motivates each change.
    - [x] Avoids breaking
    [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
    changes unless absolutely necessary.
    - [x] Testing strategy adequately addresses listed risk(s).
    - [x] Change is maintainable (easy to change, telemetry, documentation).
    - [x] Release note makes sense to a user of the library.
    - [x] Reviewer has explicitly acknowledged and discussed the performance
    implications of this PR as reported in the benchmarks PR comment.
    - [x] Backport labels are set in a manner that is consistent with the
    [release branch maintenance
    policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
    - [x] If this PR touches code that signs or publishes builds or
    packages, or handles credentials of any kind, I've requested a review
    from `@DataDog/security-design-and-guidance`.
    - [x] This PR doesn't touch any of that.
    
    ---------
    
    Co-authored-by: Yun Kim <yun.kim@datadoghq.com>
    Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com>
    Co-authored-by: Gabriele N. Tornetta <gabriele.tornetta@datadoghq.com>
    Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
    Co-authored-by: Emmett Butler <emmett.butler321@gmail.com>
    Co-authored-by: ZStriker19 <zach.groves@datadoghq.com>
    7 people committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9c2b6d4 View commit details
    Browse the repository at this point in the history